Skip to content

Fix Voronoi neighbor computation and plotting compatibility with updated SciPy and NumPy #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Edhain wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Voronoi neighbor computation and plotting compatibility with updated SciPy and NumPy #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4d5781
Update geometry.py
Edhain Nov 5, 2024
6c7d291
Update plot.py
Edhain Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vmodel/geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def voronoi_neighbors(positions: np.ndarray) -> list:
"""
tri = Delaunay(positions)
neighbors = defaultdict(set)
for p in tri.vertices:
for p in tri.simplices:
for i, j in combinations(p, 2):
neighbors[i].add(j)
neighbors[j].add(i)
Expand Down
2 changes: 1 addition & 1 deletion vmodel/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def voronoi_plot_2d(vor, ax=None, **kw):
line_style = kw.get('line_style', 'solid')

center = vor.points.mean(axis=0)
ptp_bound = vor.points.ptp(axis=0)
ptp_bound = np.ptp(vor.points, axis=0))

finite_segments = []
infinite_segments = []
Expand Down