-
Notifications
You must be signed in to change notification settings - Fork 3
Holiday offering related improvements #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
972316c to
dfbbeb3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
========================================
Coverage 99.81% 99.81%
========================================
Files 700 703 +3
Lines 34196 34369 +173
========================================
+ Hits 34133 34306 +173
Misses 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Used for scenarios where the member pays some fixed amount, and suma covers the rest of a variable pricing.
- Fix simple_redirect middleware to forward query params always - Standardize referral fields to map to utm parameter names - Add UtmCapture middleware to store utm parameters into cookies This allows the backend to keep track of utm parameters for signups that occur some time later in the code on the frontend, reading them back from cookies. The frontend does not need to know anything about utm_parameters since storing them is handled transparently via cookies. - Populate referrals on signups, based on UtmCapture cookies
We have a way to change prices but not 'expire' an offering product. This adds an endpoint and hooks up the 'delete' icon to close the offering product. Also displays closed_at in the UI. Add an 'apiSoftDelete' to resource detail grid so it will 'reload' the current grid rather than trying to redirect to the page we just edited. Add docs to ResourceDetail too. Fixed wrong resource name in the anon member contact tables.
dfbbeb3 to
2c7af30
Compare
No reason to have this anymore, it makes it much more confusing in the era of database 18n strings.
2c7af30 to
37b4496
Compare
We had `assets/index-foo.js` in the dynamic config (read from the manifest), which needs to be absolute/rooted. Instead of reading the manifest, we can just grab the src of the JS module to get the file to HEAD.
37b4496 to
cdc7f58
Compare
We don't use this and it's just confusing.
c18818b to
ac304f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin: Close offering product
We have a way to change prices but not 'expire' an offering product.
This adds an endpoint and hooks up the 'delete' icon to close
the offering product.
Also displays closed_at in the UI.
Add an 'apiSoftDelete' to resource detail grid
so it will 'reload' the current grid rather than trying
to redirect to the page we just edited.
Add docs to ResourceDetail too.
Fixed wrong resource name in the anon member contact tables.
Create referrals from UTM parameters
This allows the backend to keep track of utm parameters for signups
that occur some time later in the code on the frontend,
reading them back from cookies.
The frontend does not need to know anything about utm_parameters
since storing them is handled transparently via cookies.
Food checkout: Use markdown in fulfillment
Admin: editor multiple vendor service categories
Triggers have an 'unsubsidized amount' field
Used for scenarios where the member pays some fixed amount,
and suma covers the rest of a variable pricing.