Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/inspectionProfiles/Project_Default.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ dependencies {
implementation(project(":feature_jobs"))
implementation(project(":feature_vacansies"))
implementation(project(":core"))
implementation(project(":feature_vacancy"))

androidTestImplementation(Deps.TestDeps.androidxEspressoCore)
androidTestImplementation(Deps.TestDeps.jUnit)
Expand Down
17 changes: 16 additions & 1 deletion app/src/main/java/com/codereview/navigation/CodeReviewNavHost.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import androidx.navigation.compose.NavHost
import androidx.navigation.compose.composable
import com.codereview.feature_jobs.HomePage
import com.codereview.feature_jobs.HomeScreen
import com.codereview.feature_vacancy.VacancyScreen
import com.codereview.feature_vacansies.VacanciesScreen
import com.codereview.feature_vacansies.VacancyList

private const val VACANCIES_ARG = "vacanciesArg"
private const val VACANCY_ARG = "vacancyArg"

@Composable
fun CodeReviewNavHost(navHostController: NavHostController) {
Expand All @@ -28,7 +30,20 @@ fun CodeReviewNavHost(navHostController: NavHostController) {

composable(route = VacanciesDestination.route + "/{$VACANCIES_ARG}") { entry ->
val vacanciesArg = entry.arguments?.getString(VACANCIES_ARG)
VacanciesScreen(vacanciesArg = vacanciesArg)
VacanciesScreen(
vacanciesArg = vacanciesArg,
onNavigateToVacancy = { vacancyArg ->
navHostController
.navigateSingleTopTo(VacancyDestination.route + vacancyArg)
}
)
}
composable(route = VacancyDestination.route + "/{$VACANCY_ARG}") { entry ->
val vacancyArg = entry.arguments?.getString(VACANCY_ARG)
VacancyScreen(
vacancyId = vacancyArg,
navigateUp = { navHostController.navigateUp() }
)
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/java/com/codereview/navigation/Route.kt
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,8 @@ object HomePageDestination : Route {

object VacanciesDestination : Route {
override val route: String = "vacancies"
}

object VacancyDestination: Route {
override val route: String = "vacancy"
}
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ fun VacanciesScreen(
modifier: Modifier = Modifier,
vacanciesArg: String?,
viewModel: VacanciesViewModel = hiltViewModel(),
onNavigateToVacancy: (String) -> Unit
) {
val state by viewModel.state.collectAsStateWithLifecycle()

Expand All @@ -68,7 +69,7 @@ fun VacanciesScreen(
val vacancies = (state as VacanciesState.Ready).data
VacancyList(
vacancies = vacancies,
onVacancyClick = viewModel::onVacancyClick
onNavigateToVacancy = onNavigateToVacancy,
)
}
}
Expand All @@ -77,7 +78,7 @@ fun VacanciesScreen(
@Composable
fun VacancyList(
vacancies: List<Vacancy>,
onVacancyClick: (String) -> Unit,
onNavigateToVacancy: (String) -> Unit,
) {
LazyColumn(
Modifier
Expand All @@ -87,7 +88,8 @@ fun VacancyList(
items(vacancies) { vacancy ->
VacancyItem(
vacancy = vacancy,
onItemClick = onVacancyClick
onItemClick = onNavigateToVacancy,
idOfVacancy = vacancy.id
)
}
}
Expand All @@ -96,6 +98,7 @@ fun VacancyList(
@Composable
fun VacancyItem(
vacancy: Vacancy,
idOfVacancy: String,
onItemClick: (String) -> Unit,
) {
Column(
Expand All @@ -104,7 +107,7 @@ fun VacancyItem(
.padding(horizontal = 16.dp, vertical = 8.dp)
.clip(RoundedCornerShape(32.dp))
.background(color = Color.White)
.clickable { onItemClick(vacancy.url) },
.clickable { onItemClick("/$idOfVacancy") },
horizontalAlignment = Alignment.Start,
verticalArrangement = Arrangement.spacedBy(12.dp),
) {
Expand Down
5 changes: 4 additions & 1 deletion network/src/main/java/com/codereview/network/ApiHelper.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@ package com.codereview.network
import com.codereview.network.model.VacancyList
import com.codereview.network.model.VacancyNet
import kotlinx.coroutines.flow.Flow
import kotlinx.serialization.InternalSerializationApi

interface ApiHelper {

@OptIn(InternalSerializationApi::class)
fun getVacancyList(
limit: Int = 100,
specialities: String,
): Flow<VacancyList>

fun getVacancyDetails(id: Int): Flow<VacancyNet>
@OptIn(InternalSerializationApi::class)
fun getVacancyDetails(id: String): Flow<VacancyNet>
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import com.codereview.network.model.VacancyList
import com.codereview.network.model.VacancyNet
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.flow
import kotlinx.serialization.InternalSerializationApi
import javax.inject.Inject

class ApiHelperImpl @Inject constructor(private val apiService: ApiService) : ApiHelper {
@OptIn(InternalSerializationApi::class)
override fun getVacancyList(
limit: Int,
specialities: String,
Expand All @@ -15,7 +17,8 @@ class ApiHelperImpl @Inject constructor(private val apiService: ApiService) : Ap
emit(vacancyList)
}

override fun getVacancyDetails(id: Int): Flow<VacancyNet> = flow {
@OptIn(InternalSerializationApi::class)
override fun getVacancyDetails(id: String): Flow<VacancyNet> = flow {
emit(apiService.getVacancy(id))
}
}
8 changes: 5 additions & 3 deletions network/src/main/java/com/codereview/network/ApiService.kt
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
package com.codereview.network

import com.codereview.network.model.VacanciesNet
import com.codereview.network.model.VacancyList
import com.codereview.network.model.VacancyNet
import kotlinx.serialization.InternalSerializationApi
import retrofit2.http.GET
import retrofit2.http.Path
import retrofit2.http.Query

interface ApiService {
@OptIn(InternalSerializationApi::class)
@GET("jobs/")
suspend fun getVacancies(
@Query("skip") skip: Int = 0,
@Query("limit") limit: Int = 100,
@Query("specialities") specialities: String,
): VacancyList

@GET("api/jobs/{vacancy_id}")
@OptIn(InternalSerializationApi::class)
@GET("jobs/{vacancy_id}")
suspend fun getVacancy(
@Path("vacancy_id") vacancyId: Int
@Path("vacancy_id") vacancyId: String
): VacancyNet
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package com.codereview.network.model


import kotlinx.serialization.InternalSerializationApi
import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable

@Serializable
@InternalSerializationApi @Serializable
data class VacanciesNet(
@SerialName("total_count")
val totalCount: Int,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
package com.codereview.network.model

import kotlinx.serialization.InternalSerializationApi
import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable

@Serializable
@InternalSerializationApi @Serializable
data class VacancyList(
@SerialName("total_count" ) var totalCount : Int? = null,
@SerialName("data" ) var data : ArrayList<VacancyNet> = arrayListOf()
)

@Serializable
@InternalSerializationApi @Serializable
data class VacancyNet(
@SerialName("company_name" ) var companyName : String? = null,
@SerialName("salary" ) var salary : String? = null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.codereview.repository.vacancy_repository

import java.time.LocalDateTime
import java.time.format.DateTimeFormatter

data class Vacancy(
val id: String,
val active: Boolean,
Expand All @@ -12,7 +15,8 @@ data class Vacancy(
val title: String,
val externalId: String,
val location: String,
val internship: Boolean
val internship: Boolean,
val datePublication: String,
) {

fun getExtras(): Iterator<Pair<String, String>> {
Expand All @@ -30,4 +34,39 @@ data class Vacancy(
if (this?.isBlank() == true) "з/п не указана"
else "$this"

fun formatSalary(salary: String?): String {
return when {
salary.isNullOrBlank() -> "з/п не указана"
salary.equals("null", ignoreCase = true) -> "з/п не указана"
else -> {
val cleaned = salary
.removePrefix("$")
.replace("$", "")
.replace(",", "")
.replace(" ", "")
.replace("-", " - ")
.trim()

when {
cleaned.isEmpty() -> "з/п не указана"
cleaned.contains("RUR", ignoreCase = true) -> cleaned
.replace("RUR", " RUR")
.trim()
else -> "$cleaned \$"
}
}
}
}

fun formatDate(isoDate: String): String {
val inputFormatter = DateTimeFormatter.ISO_DATE_TIME
val outputFormatter = DateTimeFormatter.ofPattern("dd.MM.yyyy")

return try {
val dateTime = LocalDateTime.parse(isoDate, inputFormatter)
dateTime.format(outputFormatter)
} catch (e: Exception) {
"Некорректная дата"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ fun VacancyNet.toVacancy(): Vacancy = Vacancy(
title = title.toString(),
externalId = externalId ?: "",
location = location.orEmpty(),
internship = internship ?: false
internship = internship ?: false,
datePublication = datePublication ?: ""
)
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ interface VacancyRepository {
specialities: String,
): Flow<List<Vacancy>>

fun getVacancyDetails(id: Int): Flow<Vacancy>
fun getVacancyDetails(id: String): Flow<Vacancy>

}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class VacancyRepositoryImpl @Inject constructor(private val apiHelper: ApiHelper
emitAll(vacancies)
}

override fun getVacancyDetails(id: Int): Flow<Vacancy> = flow {
override fun getVacancyDetails(id: String): Flow<Vacancy> = flow {
val vacancy = apiHelper.getVacancyDetails(id).map { vacancyNet -> vacancyNet.toVacancy() }
emitAll(vacancy)
}
Expand Down
1 change: 1 addition & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ include(":feature_jobs")
include(":core")
include(":network")
include(":repository")
include(":feature_vacancy")