Add inbound call info callback. #548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlivekit
reviewed
Dec 16, 2025
| RegisterTransferSIPParticipantTopic(sipCallId string) error | ||
| DeregisterTransferSIPParticipantTopic(sipCallId string) | ||
|
|
||
| OnInboundInfo(log logger.Logger, callInfo *rpc.SIPCall, headers Headers) |
Contributor
There was a problem hiding this comment.
Why not have something more generic like OnRemoteHeaders(), applicable to both outbound and inbound?
The inbound call can stay where it is, and the outbound can happen on 200 (or any non-100 reponse)
Contributor
Author
There was a problem hiding this comment.
There's different logic here for inbound vs outbound. I could add both hooks now, but they won't do anything for now.
Contributor
There was a problem hiding this comment.
okay, would be nice, but not a showstopper.
Lets just remember to rename this to something that may apply to both directions once we introduce that.
alexlivekit
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.