Skip to content

Conversation

@RUFFY-369
Copy link

@RUFFY-369 RUFFY-369 commented Dec 26, 2025

Changes made on top of PR #488

torch==2.8.0+cu128
torchvision==0.23.0+cu128
torchaudio==2.8.0+cu128
torch==2.7.0+cu128
Copy link
Collaborator

@eliteprox eliteprox Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be kept at torch 2.8.0. Given there might be cases were we need different torch versions or constraints per "nodes.yaml". I think we should try to avoid downgrading it.

constraints.txt is currently installed early in Dockerfile.base builds and would need modified here

RUN conda run -n comfystream --cwd /workspace/comfystream --no-capture-output pip install -r src/comfystream/scripts/constraints.txt

setup_nodes.py would also need refactoring to support a dynamic constraints file

# Get the absolute path to constraints.txt
constraints_path = Path(__file__).parent / "constraints.txt"
if not constraints_path.exists():
print(f"Warning: constraints.txt not found at {constraints_path}")

I've also considered supporting multiple torch versions using optional deps in comfystream or refactoring to use uv which supports env vars for the constraints file. Any ideas on how to make this more flexible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants