Skip to content

api/usage: Make response JSON fields camelCase #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victorges wants to merge 1 commit into
base: main
Choose a base branch
from
Open

api/usage: Make response JSON fields camelCase #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions usage/bigquery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ var allowedTimeSteps = map[string]bool{
}

type UsageSummaryRow struct {
UserID string `bigquery:"user_id"`
CreatorID string `bigquery:"creator_id"`
UserID string `bigquery:"user_id" json:"userId"`
CreatorID string `bigquery:"creator_id" json:"creatorId"`

DeliveryUsageMins float64 `bigquery:"delivery_usage_mins"`
TotalUsageMins float64 `bigquery:"transcode_total_usage_mins"`
StorageUsageMins float64 `bigquery:"storage_usage_mins"`
DeliveryUsageMins float64 `bigquery:"delivery_usage_mins" json:"deliveryUsageMins"`
TotalUsageMins float64 `bigquery:"transcode_total_usage_mins" json:"totalUsageMins"`
Copy link
Member Author

@victorges victorges Jun 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, should this be TranscodeUsageMins (or "TranscodeTotalUsageMins") instead? As I think it was stated in other places "total usage" is not very clear about what it means, as it is not really the total usage from the perspective of counting delivery and storage as well.

StorageUsageMins float64 `bigquery:"storage_usage_mins" json:"storageUsageMins"`
}

type BigQuery interface {
Expand Down