Skip to content

Fuzzy match pixel count, add more decoder stats #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cyberj0g wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fuzzy match pixel count, add more decoder stats #366

cyberj0g wants to merge 5 commits into from

Conversation

@cyberj0g
Copy link
Contributor

@cyberj0g cyberj0g commented Jan 20, 2023 •
edited
Loading

  • Add fuzzy pixel matching function to work around pixel count mismatch issue: Broadcaster's validation fails for vertical videos go-livepeer#2649
  • Move decoder stats extraction function from go-livepeer
  • Add width and height to decoder stats written when transcoding (does not account for mid-segment resolution changes!)
  • Caveat: the TestTranscoder_ResolutionsAndPixels fails, when LPMS_USE_NEW_TRANSCODE is set, probably because of frame count mismatch.

@cyberj0g cyberj0g mentioned this pull request Jan 20, 2023
Open
@cyberj0g cyberj0g force-pushed the ip/portrait-pixel-mismatch branch from e81f8ba to eed78df Compare January 27, 2023 09:18
@cyberj0g cyberj0g changed the title Update portrait test to verify pixel count Fuzzy match pixel count, add more decoder stats Jan 27, 2023
@cyberj0g cyberj0g marked this pull request as ready for review January 27, 2023 09:35
@cyberj0g cyberj0g mentioned this pull request Feb 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexKordic AlexKordic Awaiting requested review from AlexKordic

@thomshutt thomshutt Awaiting requested review from thomshutt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyberj0g