Skip to content

Revert "prepare: effectiveProfile to avoid dimensions shorter than 14… #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
figintern wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "prepare: effectiveProfile to avoid dimensions shorter than 14… #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions task/prepare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ import (
const (
minVideoBitrate = 100_000
absoluteMinVideoBitrate = 5_000
// NVIDIA cards with Turing architecture enforce a minimum width/height of 145 pixels on transcoded videos
minVideoDimensionPixels = 145
)

var allProfiles = []api.Profile{
Expand Down Expand Up @@ -134,11 +132,8 @@ func getPlaybackProfiles(assetVideoSpec *api.AssetVideoSpec) ([]api.Profile, err
return nil, fmt.Errorf("no video track found in asset spec")
}
filtered := make([]api.Profile, 0, len(allProfiles))
for _, baseProfile := range allProfiles {
profile := effectiveProfile(baseProfile, video)
lowerQualityThanSrc := profile.Height <= video.Height && profile.Bitrate < int(video.Bitrate)
compliesToMinSize := profile.Height >= minVideoDimensionPixels && profile.Width >= minVideoDimensionPixels
if lowerQualityThanSrc && compliesToMinSize {
for _, profile := range allProfiles {
if profile.Height <= video.Height && profile.Bitrate < int(video.Bitrate) {
filtered = append(filtered, profile)
}
}
Expand All @@ -148,15 +143,6 @@ func getPlaybackProfiles(assetVideoSpec *api.AssetVideoSpec) ([]api.Profile, err
return filtered, nil
}

func effectiveProfile(profile api.Profile, video *api.AssetTrack) api.Profile {
if video.Width >= video.Height {
profile.Height = profile.Width * video.Height / video.Width
} else {
profile.Width = profile.Height * video.Width / video.Height
}
return profile
}

func lowBitrateProfile(video *api.AssetTrack) api.Profile {
bitrate := int(video.Bitrate / 3)
if bitrate < minVideoBitrate && video.Bitrate > minVideoBitrate {
Expand Down