Skip to content

chore: migrate biome version #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
junhyr merged 2 commits into from
Jun 27, 2025
Merged

chore: migrate biome version #618

junhyr merged 2 commits into from
Jun 27, 2025

Conversation

@junhyr
Copy link
Collaborator

@junhyr junhyr commented Jun 26, 2025

Description

Concise description of proposed changes

Additional Information

@junhyr junhyr requested a review from a team as a code owner June 26, 2025 15:06
@vercel
Copy link

vercel bot commented Jun 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coinbase-lvpr-tv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 9:38am
lvpr-tv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 9:38am
ui-kit-docs-embed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 9:38am
ui-kit-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 9:38am
ui-kit-next-pages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 9:38am
ui-kit-with-pubnub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 9:38am

@junhyr junhyr requested a review from leszko June 26, 2025 15:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 26, 2025
View reviewed changes
packages/react/src/player/RateSelect.tsx

import type { PlaybackRate } from "@livepeer/core/media";
// biome-ignore lint/correctness/noUnusedImports: ignored using `--suppress`
import { composeEventHandlers } from "@radix-ui/primitive";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import composeEventHandlers.

Copilot Autofix

AI 6 months ago

To fix the issue, the unused import composeEventHandlers should be removed from the code. This will improve code clarity and maintainability. The change involves deleting the import statement on line 5. No additional changes are required since the import is not used elsewhere in the provided code.

Suggested changeset 1
packages/react/src/player/RateSelect.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/react/src/player/RateSelect.tsx b/packages/react/src/player/RateSelect.tsx
--- a/packages/react/src/player/RateSelect.tsx
+++ b/packages/react/src/player/RateSelect.tsx
@@ -4,3 +4,2 @@
 // biome-ignore lint/correctness/noUnusedImports: ignored using `--suppress`
-import { composeEventHandlers } from "@radix-ui/primitive";
 import React, { useCallback } from "react";
EOF
@@ -4,3 +4,2 @@
// biome-ignore lint/correctness/noUnusedImports: ignored using `--suppress`
import { composeEventHandlers } from "@radix-ui/primitive";
import React, { useCallback } from "react";
Copilot is powered by AI and may make mistakes. Always verify output.
packages/react/src/player/Volume.tsx

import { warn } from "@livepeer/core/utils";
// biome-ignore lint/correctness/noUnusedImports: ignored using `--suppress`
import { composeEventHandlers } from "@radix-ui/primitive";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import composeEventHandlers.

Copilot Autofix

AI 6 months ago

To fix the problem, the unused import composeEventHandlers should be removed from the file. This involves deleting the line where it is imported. No other changes are necessary, as the removal does not affect the functionality of the code.

Suggested changeset 1
packages/react/src/player/Volume.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/react/src/player/Volume.tsx b/packages/react/src/player/Volume.tsx
--- a/packages/react/src/player/Volume.tsx
+++ b/packages/react/src/player/Volume.tsx
@@ -4,3 +4,2 @@
 // biome-ignore lint/correctness/noUnusedImports: ignored using `--suppress`
-import { composeEventHandlers } from "@radix-ui/primitive";
 import { Presence } from "@radix-ui/react-presence";
EOF
@@ -4,3 +4,2 @@
// biome-ignore lint/correctness/noUnusedImports: ignored using `--suppress`
import { composeEventHandlers } from "@radix-ui/primitive";
import { Presence } from "@radix-ui/react-presence";
Copilot is powered by AI and may make mistakes. Always verify output.
leszko
leszko approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix @junhyr

There is still this Main / Security failure. Any thoughts how to solve it?
image

@junhyr junhyr merged commit 93eb814 into main Jun 27, 2025
14 checks passed
@junhyr junhyr deleted the jun/change branch June 27, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leszko leszko leszko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@junhyr @leszko