Truncate sidebar item text #2340
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario
A sidebar item with long text will overflow
The problem
The user can't just apply
truncateto the sidebar item because the class will be applied to a parent div:This would require a tailwind selector that targets the child element:
The solution
I think it's reasonable to truncate by default, which is what this PR does.
An alternative could be a prop enabling this behavior:
<flux:sidebar.item truncate>Fixes #2336