fix: handle null responses from model providers#37
Open
Conversation
When upstream providers return null responses, the gateway now properly handles them by returning error responses instead of crashing. This prevents TypeError in the stream generator and allows the OpenAI agents SDK to properly handle the error. Fixes cases where agent framework gets "ModelBehaviorError: Model did not produce a final response" due to invalid response handling. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
chtushar
force-pushed
the
chtushar/model-final-response-err
branch
from
dca01a7 to
d83633a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When upstream providers return null responses, the gateway now properly handles them by returning error responses instead of crashing. This prevents TypeError in the stream generator and allows the OpenAI agents SDK to properly handle the error.
Fixes cases where agent framework gets "ModelBehaviorError: Model did not produce a final response" due to invalid response handling.
Changes
OpenAIModelResponseJSONToStreamGenerator(streaming mode)OpenAICreateModelResponseTransformer(non-streaming mode)null_responsewhen upstream returns null🤖 Generated with Claude Code