Make Sycl resource more consist with other resources #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Sycl::get_queue returns a reference instead of a pointer
rhornung67
reviewed
Aug 28, 2025
| static sycl::queue& get_a_queue(const sycl::context* syclContext, | ||
| int num) | ||
| { | ||
| static constexpr int num_queues = 16; |
Member
There was a problem hiding this comment.
Should we make something like this a configure option so it's easier to change if necessary for different architectures? Or, is it expected to always be 16?
Member
Author
There was a problem hiding this comment.
That's not a bad idea.
Member
Author
|
This adds a user settable default resource per thread, which may also be useful to have for the other GPU backends. It adds a bit more overhead as the global is not a thread_local instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change some parts of the Sycl resource to be more consistent with other resources.
These involve breaking changes and should not be merged until the next major release.