Skip to content

Conversation

@IdoAkkerman
Copy link
Collaborator

@IdoAkkerman IdoAkkerman commented Nov 21, 2025

This PR does three related things -- in order of impact/controversialness(sic):

  1. It rationalized/simplifies the CMake routines.
  • In the old routines the MFEM library defaulted to dependencies/mfem even if another mfem was provided
  • The mfem is imported as a packages, this simplifies things
  • Examples and tests are handled in there own directory, this simplifies the routines
  1. Switched to c++23 to accommodate MFEM
  • This created issues with std
  • Removed using namespace std from the library and examples
  1. Fixed some other (pedantic) compiler errors
  • Added some override statements
  • Made a constructor virtual
  • Separate delete statement for different variables
  • Corrected a string comparison

@IdoAkkerman
Copy link
Collaborator Author

This PR address issues also tackled in PR #318

@IdoAkkerman IdoAkkerman added the RFR Ready for review label Nov 28, 2025
Copy link
Collaborator

@ckendrick ckendrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! This looks good to me and works as expected.

@ckendrick ckendrick mentioned this pull request Dec 1, 2025
@ckendrick ckendrick merged commit 00289e1 into master Dec 3, 2025
7 checks passed
@dylan-copeland dylan-copeland deleted the fix-compile-warnings branch December 3, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants