Skip to content

Conversation

@lalaniket8
Copy link
Contributor

Pre-commit to check for exec mask instruction changes caused by ROCm#789

ronlieb and others added 30 commits November 11, 2025 20:45
Added function configure_pkg to install changelog, copyright, and
lintian override for debian.
Install changelog, copyright, and lintian override files to fix lintian
errors:
no-copyright-file
debian-changelog-file-missing
dir-or-file-in-opt
We're currently using a variable/parameter that no longer exists in the
scope of the function, so we get a compilation error. Fix to align with
the upstream PR and use Ptr.
xfails: needs pranav to look into
 flang/test/Lower/OpenMP/DelayedPrivatization/target-private-allocatable.f90
 flang/test/Lower/OpenMP/optional-argument-map-2.f90
#573)

… (llvm#166459)

Update revert_patches.txt

Co-authored-by: Nick Sarnie <nick.sarnie@intel.com>
Here's the list of openmpvv fails (across OMP 4.5, 5.0, 5.1, 5.2):
test_target_taskloop_shared.c
test_target_teams_distribute_parallel_for_if_parallel_modifier.c
declare_target_base_and_derived_class.cpp
declare_target_base_class.cpp
test_loop_bind_device.c
test_loop_nested_device.c
test_loop_nested_device.F90
test_master_taskloop_device.c
test_master_taskloop_simd_device.c
test_parallel_master_device.c
test_parallel_master_taskloop_device.c
test_parallel_master_taskloop_simd_device.c
test_target_depend_lvalue_func.cpp
test_target_depend_lvalue_ptr.cpp
test_target_depend_lvalue_ternary.cpp
test_target_task_depend_mutexinoutset.c
test_depend_inout_omp_all_memory.c
test_target_depend_out_omp_all_memory.c
test_taskloop_simd_order_reproducible_device.c
test_taskloop_simd_order_unconstrained_device.c
test_task_target_default_firstprivate.c
test_target_VirFunc.cpp

smoke-dev:
clang-nested-parallel-for
red_bug_51
xteam-red-sched-default-option

All runtime fails with the same memory fault signature Michael posted
earlier.

This reverts commit 2f0e563.
If LIBOMP_INSTALL_RPATH is present, do not add implicit rpath. This
fixes an issue with ROCm RHEL-10 RPATH rules that deem /opt/rocm an
invalid path.
This patch reenables tests that had been xfailed in a previous merge
(#575) by Ron.

1. test/Lower/OpenMP/DelayedPrivatization/target-private-allocatable.f90
Fixed test to accommodate map_clauses related to descriptors that we do
not have upstream.
2. test/Lower/OpenMP/optional-argument-map-2.f90 Same problem as above
in addition to a bad merge that enabled some testing that had been
deliberately disabled by Andrew on amd-staging in the past. See commit
706196c
@lalaniket8 lalaniket8 requested review from a team, kuhar and rengolin as code owners December 14, 2025 09:20
@lalaniket8 lalaniket8 requested review from cmc-rep, jmmartinez and vg0204 and removed request for a team, Groverkss, PeimingLiu, aartbik and yinying-lisa-li December 14, 2025 09:20
@lalaniket8
Copy link
Contributor Author

Incorrect base branch

@lalaniket8 lalaniket8 closed this Dec 14, 2025
@lalaniket8 lalaniket8 changed the title Pre-commit preliminary tests to check for Non-SSA Exec mask instructions [CLOSED] Pre-commit preliminary tests to check for Non-SSA Exec mask instructions Dec 14, 2025
@lalaniket8 lalaniket8 deleted the amd/dev/lalaniket8/wave-transform-tests branch December 14, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.