[HIP] Add an --offload-arch option to hip-tpl.py #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a
--offload-arch=...option, that we can use to switch the target architecture. This can be a string such as'gfx{version}', or'amdgcnspirv'.This option defaults to 'gfx90a' such that if it is not specified, we keep the old behavior (
'gfx90a'was hardcoded).If we pass an incorrect option we get:
$ ./hip-tpl.py --offload-arch=aaa usage: hip-tpl.py [-h] [--offload-arch OFFLOAD_ARCH] hip-tpl.py: error: argument --offload-arch: invalid amdgpu_target value: 'aaa'And for the help: