feat: add lud21 verify base spec. #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added as optional in advanced settings - api endpoint returning the success response
dni
requested review from
arcbtc,
blackcoffeexbt,
motorina0 and
talvasconcelos
motorina0
reviewed
Nov 4, 2025
|
|
||
| if link.verify: | ||
| verify_url = request.url_for( | ||
| "lnurlp.api_lnurl_verify", payment_hash=payment.payment_hash |
Collaborator
There was a problem hiding this comment.
The LUD does not specify that the check value must be the payment hash.
Can't this in fact be a vulnerability? Anyone that sees the QR code can check the payment status (and obtain the pre-image).
Suggestion:
- use
verify_secretrandom value - introduce
extracolumn (not to have such a large number of migrations)
Member
Author
There was a problem hiding this comment.
the payment_hash is actually inside the bolt11 invoice
Member
Author
There was a problem hiding this comment.
no reason for adding anything extra, the verify link is sent with the bolt11 invoice which contains the payment_hash already, so there is no additional information leaked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #79