[4.2.x] Backport null adapter#19
Open
ziggythehamster wants to merge 2 commits intolocalytics:v4.2.xfrom
Open
Conversation
divoxx
pushed a commit
to doximity/odbc_adapter
that referenced
this pull request
Aug 11, 2023
* MOJ-343 Active Record does support, even if it's not well documented, a method of automatically getting IDs from the database. Implemented this native method to deal with an issue with ActiveStorage. * MOJ-450 Removed the EasyIdentified concern & corrected a minor bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The null adapter change was a pretty sensible one in the master branch, but I need it in the 4.2.x branch. This PR backports this functionality.
Without #18, this PR will fail in Travis, so here's a link to it passing in our repo.