Update splt.js: Support html entity decoding #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey Logan, after failing to workaround this issue around spltjs due to the nature of .innerHTML always escaping those HTML entities I tried to apply some changes to your script instead which finally worked. It would be nice if you'd merge this proposal one way or another. The methode used to decode those entities (by using textarea elements) might not be the smartest but it's definitely an easy one and working. Maybe see https://thelinuxcode.com/decode-html-entities-javascript/ for reference. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Logan,
after failing to workaround this issue around spltjs due to the nature of .innerHTML always escaping those HTML entities I tried to apply some changes to your script instead which finally worked. It would be nice if you'd merge this proposal one way or another. The method used to decode those entities (by using textarea elements) might not be the smartest but it's definitely an easy one and working. Maybe see https://thelinuxcode.com/decode-html-entities-javascript/ for reference. Thanks!