Skip to content

String optimization #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkuppitz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

String optimization #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a717c4c
used StringBuilder for string concatenation
dkuppitz Mar 7, 2013
e0de405
simplified the creation of query strings
dkuppitz Mar 7, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 47 additions & 63 deletions loggr-dotnet/LogClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
using System;
using System.Collections.Generic;
using System.Text;
using System.Web;
using System.Net;
using System.Collections.Specialized;
using System.Diagnostics;
using System.Globalization;
using System.Web;

namespace Loggr
{
Expand Down Expand Up @@ -294,102 +293,87 @@ protected void MergeConfigurationWithEvent(Event eventObj)

protected string CreateEventQuerystring(Event eventObj)
{
string qs = "";
AppendQuerystringNameValue("text", eventObj.Text, ref qs, 500);
AppendQuerystringNameValue("link", eventObj.Link, ref qs, 200);
AppendQuerystringNameValueList("tags", eventObj.Tags, ref qs, 200);
AppendQuerystringNameValue("source", eventObj.Source, ref qs, 200);
AppendQuerystringNameValue("user", eventObj.User, ref qs, 200);
var parameters = new NameValueCollection
{
{ "text", Cap(eventObj.Text, 500) },
{ "link", Cap(eventObj.Link, 200) },
{ "tags", Cap(eventObj.Tags.ToArray(), 200) },
{ "source", Cap(eventObj.Source, 200) },
{ "user", Cap(eventObj.User, 200) },
};

if (eventObj.DataType == DataType.html)
{
AppendQuerystringNameValue("data", "@html" + Environment.NewLine + eventObj.Data, ref qs, 5120);
parameters.Add("data", Cap(string.Concat("@html", Environment.NewLine, eventObj.Data), 5120));
}
else if (eventObj.DataType == DataType.json)
{
AppendQuerystringNameValue("data", "@json" + Environment.NewLine + eventObj.Data, ref qs, 5120);
parameters.Add("data", Cap(string.Concat("@json", Environment.NewLine, eventObj.Data), 5120));
}
else
{
AppendQuerystringNameValue("data", eventObj.Data, ref qs, 5120);
parameters.Add("data", Cap(eventObj.Data, 5120));
}

if (eventObj.Timestamp.HasValue)
{
AppendQuerystringNameValueDate("timestamp", eventObj.Timestamp, ref qs, 30);
parameters.Add("timestamp", Cap(DateToMilliseconds(eventObj.Timestamp.Value), 30));
}

if (eventObj.Value.HasValue)
{
AppendQuerystringNameValueObject("value", eventObj.Value.Value, ref qs, 30);
parameters.Add("value", Cap(eventObj.Value.Value, 30));
}

if (eventObj.Geo != null)
{
AppendQuerystringNameValueObject("geo", eventObj.Geo, ref qs, 30);
parameters.Add("geo", Cap(eventObj.Geo, 30));
}
return qs;
}

protected string CreateUserQuerystring(string username, string email, string page)
{
string qs = "";
AppendQuerystringNameValue("user", username, ref qs, 100);
AppendQuerystringNameValue("email", email, ref qs, 100);
AppendQuerystringNameValue("page", page, ref qs, 100);

return qs;
return ConvertToQueryString(parameters);
}

protected object AppendQuerystringNameValue(string name, string value, ref string querystring, int length)
protected string CreateUserQuerystring(string username, string email, string page)
{
if (string.IsNullOrEmpty(value))
return querystring;
if (querystring.Length > 0)
querystring += "&";
querystring += string.Format("{0}={1}", name, HttpUtility.UrlEncode(Cap(value, length)));
return querystring;
return ConvertToQueryString(new NameValueCollection
{
{"user", Cap(username, 100) },
{"email", Cap(email, 100) },
{"page", Cap(page, 100) }
});
}

protected object AppendQuerystringNameValueObject(string name, object value, ref string querystring, int length)
protected static double DateToMilliseconds(DateTime input)
{
if (querystring.Length > 0)
querystring += "&";
querystring += string.Format("{0}={1}", name, HttpUtility.UrlEncode(Cap(value.ToString(), length)));
return querystring;
return (input - new DateTime(1970, 1, 1, 0, 0, 0)).TotalMilliseconds;
}

protected object AppendQuerystringNameValueList(string name, List<string> value, ref string querystring, int length)
protected static string Cap(string input, int length)
{
if (value.Count == 0)
return querystring;
if (querystring.Length > 0)
querystring += "&";
querystring += string.Format("{0}={1}", name, HttpUtility.UrlEncode(Cap(string.Join(" ", value.ToArray()), length)));
return querystring;
if (length < 0)
throw new ArgumentOutOfRangeException("Length", length, "Length must be > 0");
else if (length == 0 || input == null || input.Length == 0)
return string.Empty;
else if (input.Length <= length)
return input;
else
return input.Substring(0, length);
}

protected object AppendQuerystringNameValueDate(string name, DateTime? value, ref string querystring, int length)
protected static string Cap(string[] input, int length)
{
if (!value.HasValue)
return querystring;
if (querystring.Length > 0)
querystring += "&";
querystring += string.Format("{0}={1}", name, HttpUtility.UrlEncode(Cap(DateToMilliseconds(value.Value).ToString(), length)));
return querystring;
return Cap(string.Join(" ", input), length);
}

protected double DateToMilliseconds(DateTime input)
protected static string Cap(double input, int length)
{
return (input - new DateTime(1970, 1, 1, 0, 0, 0)).TotalMilliseconds;
return Cap(input.ToString(CultureInfo.InvariantCulture), length);
}

protected string Cap(string input, int length)
protected static string ConvertToQueryString(NameValueCollection nvc)
{
if (length < 0)
throw new ArgumentOutOfRangeException("Length", length, "Length must be > 0");
else if (length == 0 || input.Length == 0)
return "";
else if (input.Length <= length)
return input;
else
return input.Substring(0, length);
return string.Join("&", Array.ConvertAll(nvc.AllKeys,
key => string.Format("{0}={1}", HttpUtility.UrlEncode(key), HttpUtility.UrlEncode(nvc[key]))));
}

#endregion
Expand Down
103 changes: 58 additions & 45 deletions loggr-dotnet/Utility/ExceptionFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Data;
using System.Diagnostics;
using System.Globalization;
using System.Text;
using System.Web;

namespace Loggr.Utility
Expand Down Expand Up @@ -60,69 +61,81 @@ public static string Format(Exception ex)

public static string Format(Exception ex, object traceObject)
{
string res = "";

// send basic info
res += string.Format("<b>Exception</b>: {0}<br />", ex.Message);
res += string.Format("<b>Type</b>: {0}<br />", ex.GetType().ToString());
res += string.Format("<b>Machine</b>: {0}<br />", System.Environment.MachineName);

res += "<br />";
var res = new StringBuilder()

.AppendFormat("<b>Exception</b>: {0}<br />", ex.Message)
.AppendFormat("<b>Type</b>: {0}<br />", ex.GetType())
.AppendFormat("<b>Machine</b>: {0}<br />", System.Environment.MachineName)
.Append("<br />")
.Append(GetFormattedWebDetails(HttpContext.Current))
.Append(GetFormattedTraceObject(traceObject))
.Append("<br />")
.Append("<b>Stack Trace</b><br />")
.Append("<br />")
.Append(GetFormattedStackTrace(ex));

return res.ToString();
}

// see if we have web details
if (HttpContext.Current != null)
private static string GetFormattedWebDetails(HttpContext ctx)
{
if (ctx != null)
{
res += string.Format("<b>Request URL</b>: {0}<br />", HttpContext.Current.Request.Url.ToString());
res += string.Format("<b>Is Authenticated</b>: {0}<br />", (HttpContext.Current.User.Identity.IsAuthenticated ? "True" : "False"));
res += string.Format("<b>User</b>: {0}<br />", (HttpContext.Current.User.Identity.IsAuthenticated ? HttpContext.Current.User.Identity.Name : "anonymous"));
res += string.Format("<b>User host address</b>: {0}<br />", HttpContext.Current.Request.ServerVariables["REMOTE_ADDR"]);
res += string.Format("<b>Request Method</b>: {0}<br />", HttpContext.Current.Request.ServerVariables["REQUEST_METHOD"]);
res += string.Format("<b>User Agent</b>: {0}<br />", HttpContext.Current.Request.ServerVariables["HTTP_USER_AGENT"]);
res += string.Format("<b>Referer</b>: {0}<br />", HttpContext.Current.Request.ServerVariables["HTTP_REFERER"]);
res += string.Format("<b>Script Name</b>: {0}<br />", HttpContext.Current.Request.ServerVariables["SCRIPT_NAME"]);
var res = new StringBuilder()

.AppendFormat("<b>Request URL</b>: {0}<br />", ctx.Request.Url)
.AppendFormat("<b>Is Authenticated</b>: {0}<br />", ctx.User.Identity.IsAuthenticated ? "True" : "False")
.AppendFormat("<b>User</b>: {0}<br />", ctx.User.Identity.IsAuthenticated ? ctx.User.Identity.Name : "anonymous")
.AppendFormat("<b>User host address</b>: {0}<br />", ctx.Request.ServerVariables["REMOTE_ADDR"])
.AppendFormat("<b>Request Method</b>: {0}<br />", ctx.Request.ServerVariables["REQUEST_METHOD"])
.AppendFormat("<b>User Agent</b>: {0}<br />", ctx.Request.ServerVariables["HTTP_USER_AGENT"])
.AppendFormat("<b>Referer</b>: {0}<br />", ctx.Request.ServerVariables["HTTP_REFERER"])
.AppendFormat("<b>Script Name</b>: {0}<br />", ctx.Request.ServerVariables["SCRIPT_NAME"]);

return res.ToString();
}
else return null;
}

private static string GetFormattedTraceObject(object traceObject)
{
if (traceObject != null)
{
res += "<br />";
res += "<b>Traced Object(s)</b><br />";
res += "<br />";
if (traceObject != null)
{
res += ObjectDumper.DumpObject(traceObject, 1);
}
else
{
res += "Not specified<br />";
}
}

res += "<br />";
res += "<b>Stack Trace</b><br />";
res += "<br />";
var res = new StringBuilder()

FormatStack(ex, ref res);
.Append("<br />")
.Append("<b>Traced Object(s)</b><br />")
.Append("<br />")
.Append(ObjectDumper.DumpObject(traceObject, 1));

return res;
return res.ToString();
}
else return null;
}

protected static void FormatStack(Exception Ex, ref string Buffer)
private static string GetFormattedStackTrace(Exception ex)
{
if (Ex.InnerException != null)
var res = new StringBuilder();

if (ex.InnerException != null)
{
FormatStack(Ex.InnerException, ref Buffer);
res.Append(GetFormattedStackTrace(ex.InnerException));
}
Buffer += string.Format("[{0}: {1}]<br />", Ex.GetType().ToString(), Ex.Message);
if (Ex.StackTrace != null)

res.AppendFormat("[{0}: {1}]<br />", ex.GetType(), ex.Message);

if (ex.StackTrace != null)
{
Buffer += Ex.StackTrace.Replace(Environment.NewLine, "<br />");
res.Append(HttpUtility.HtmlEncode(ex.StackTrace).Replace(Environment.NewLine, "<br />"));
}
else
{
Buffer += "No stack trace";
res.Append("No stack trace");
}
Buffer += "<br/>";
Buffer += "<br/>";

res.Append("<br/><br/>");

return res.ToString();
}
}
}