-
Notifications
You must be signed in to change notification settings - Fork 16
Add Hisource HI-K0402WS pictures #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the pictures. |
|
Removed. |
logicog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work, one can see all the additional work behind the scenes that was necessary!
config.txt
Outdated
| ip 192.168.10.247 | ||
| gw 192.168.10.1 | ||
| ip 192.168.4.247 | ||
| gw 192.168.4.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take this out again, as it is not specific to this device.
debug.h
Outdated
| @@ -1,6 +1,9 @@ | |||
| #define DEBUG | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take this out again, as it is not specific to this device.
machine.h
Outdated
| * Select your machine type below | ||
| */ | ||
| #define MACHINE_KP_9000_6XHML_X2 | ||
| // #define MACHINE_KP_9000_6XHML_X2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change machine.h to merely add the define for the K0402WS, commented out? Otherwise it will be affecting the default. We will need a different solution than having the machine selected defined in machine.h, that is now clear. Possibly a define on the make command line. Maybe you have an idea?
|
Sorry - it wasn't clear that these additional commit were added to this PR. This PR should only contain the pictures - all else is cleanly contained in #97 ... with all the issues already resolved. |
|
You can use |
|
@logicog fixed it - what a horrible tool. |
No description provided.