Add index parameter to filterMap callback signature#2
Merged
Conversation
Co-authored-by: lohmander <2197050+lohmander@users.noreply.github.com>
- Updated Maybe.filterMap to accept (value, index) callback - Updated AsyncMaybe.filterMap to accept (value, index) callback - Updated functional filterMap wrapper to pass index parameter - Added comprehensive tests for all three implementations - All tests passing (109 tests) Co-authored-by: lohmander <2197050+lohmander@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update filterMap to include index parameter
Add index parameter to filterMap callback signature
Nov 4, 2025
lohmander
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filterMapmethod callback only received the array element value, inconsistent with standard JavaScript array methods likemapandfilterwhich provide both value and index.Changes
fn: (value: U, index: number) => Maybe<V>fn: (value: U, index: number) => Maybe<V>filterMapoverloads to include index parameterUsage
The change is backward compatible—existing code without index parameter continues to work.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.