Fix "Max number of dynamics shortcuts exceed" error & add a few features#4
Open
CharlesMangwa wants to merge 4 commits intolokyoung:masterfrom
Open
Fix "Max number of dynamics shortcuts exceed" error & add a few features#4CharlesMangwa wants to merge 4 commits intolokyoung:masterfrom
CharlesMangwa wants to merge 4 commits intolokyoung:masterfrom
Conversation
1. We we try to set more than 1 app shortcut, the app returns a red screen [Max number of dynamics shortcuts exceed](https://goo.gl/LdmqTm). This should not be the case anymore 👍 2. ShortcutInfo.Builder supports a `setRank` method, which could be pretty handy in some use cases. This PR adds the support of an `order` property inside the `RNAppShortcuts.addShortcut()` method. Thus, we are able to set the shortcuts order dynamically for instance, and do something like this: ```js import React from 'react' import RNAppShortcuts from 'react-native-app-shortcuts' ... export class Example extends React.Component { state = { appShortcuts: [ { id: '/app/search', shortLabel: 'Search', longLabel: 'Search somthing', iconFolderName: 'drawable', iconName: 'search', order: 2, }, { id: '/app/article/new', shortLabel: 'New', longLabel: 'New article', iconFolderName: 'drawable', iconName: 'pen', order: 0, }, { id: '/app/notifications', shortLabel: 'Notifs', longLabel: 'Notifications', iconFolderName: 'drawable', iconName: 'clock', order: 1, }, ] } // Will generate shortcuts: 'New Article' -> 'Notifications' -> 'Search' (from top to bottom) _createDynamicAppShortcuts = () => this.state.data.map(shortcut => AppShortcuts.addShortcut(shortcut)) render() { this._createDynamicAppShortcuts() return ( ... ) } } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be the case anymore because we now make sure to not exceed the
shortcutManager.getMaxShortcutCountPerActivity👍ShortcutInfo.Buildersupports asetRankmethod, which could be pretty handy in some use cases. This PR adds the support of anorderproperty inside theRNAppShortcuts.addShortcut()method. Thus, we are able to set the shortcuts order dynamically for instance, and do something like this:react-native-app-shortcutsis also able to redirect the user to theMainActivitywhen the back button is pressed right after using a shortcut. The previous behaviour was leaving the app.