This repository was archived by the owner on Oct 1, 2023. It is now read-only.
Add fixes after live testing with more services#6
Open
sbtsrbayer wants to merge 3 commits intoloren138:masterfrom
Open
Add fixes after live testing with more services#6sbtsrbayer wants to merge 3 commits intoloren138:masterfrom
sbtsrbayer wants to merge 3 commits intoloren138:masterfrom
Conversation
loren138
approved these changes
Aug 31, 2018
loren138
suggested changes
Aug 31, 2018
| Route::get('/proxyValidate', '\Loren138\CASServer\Http\Controllers\CasController@getProxyValidate'); | ||
| // CAS 3.0 Validate | ||
| Route::get('/p3/serviceValidate', '\Loren138\CASServer\Http\Controllers\CasController@getServiceValidate3'); | ||
| Route::get('/p3/proxyValidate', '\Loren138\CASServer\Http\Controllers\CasController@getProxyValidate3'); |
Owner
There was a problem hiding this comment.
Can you add tests for the 5 new endpoints (even if some of them are duplicates of existing tests)? (You could just factor out the duplicate code into a test helper method.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the documentation:
https://apereo.github.io/cas/5.2.x/protocol/CAS-Protocol-V2-Specification.html
"If the certificate fails validation, no proxy-granting ticket will be issued, and the CAS service response as described in Section 2.5.2 MUST NOT contain a block. "
I had to remove this from the xml response view to get Canvas to authenticate.
Canvas also defaulted to the proxyService eventhough it didn't need to proxy.
There were some routes expected by 3rd parties that needed to be added too.