-
-
Notifications
You must be signed in to change notification settings - Fork 123
loro-wasm replaceWithShallow #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
canadaduane
wants to merge
7
commits into
loro-dev:main
Choose a base branch
from
canadaduane:loro-wasm-replace-with-shallow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d45a43b
feat: add arena generation counter for handler invalidation
canadaduane e95dd6a
feat: handler generation-based caching
canadaduane b2def00
feat: add swap_internals_from to swap internal doc data
canadaduane c991bb0
feat: replace_with_shallow loro internal function
canadaduane d0ece61
feat: subscription container_id storage
canadaduane 2a8c952
feat: preserve subscriptions on replace_with_shallow
canadaduane 50aef14
feat: add replaceWithShallow to loro-wasm
canadaduane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unicode_startis recomputed during decode viaalloc_str_with_slice(seeencoding/outdated_encode_reordered.rs:228-233), but diff calculation later resolves those ranges throughoplog.arena.slice_by_unicode(diff_calc.rs:1096-1097). When history before the shallow frontier contains text inserts, keeping the old string arena here means the swapped-in ranges point into the wrong prefix, so checkouts/diffs can return unrelated text afterreplace_with_shallow. The string arena should be swapped (or rebuilt) along with the rest of the arena contents.Useful? React with 👍 / 👎.