Open
Conversation
This will give people an option to 'logout'
Owner
There was a problem hiding this comment.
Do you envision this method being called when a User instance is available? My guess is that a logout endpoint would unfold like so:
- Verify the provided access token and retrieve the current user
- Delete the access token
If that flow is correct, would it be more appropriate to bind this method to the instance? e.g.
def delete_bearer_token(self, token):
self.token_model.get_key(self.get_id(), 'bearer', token).delete()Feel free to disagree. And thanks again for the PR!
Owner
|
Hey @mez, are you interested in making the suggested change? I'm happy to do it as well, since it sounds like we're in agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will give people an option to 'logout'. so making a handler to process the delete() can call this method to remove the token.