Fix push subscription cleanup for 404 and 410 errors#20
Merged
Conversation
Handle both 404 (Not Found) and 410 (Gone) status codes when push notifications fail. This properly removes stale subscriptions when: - Users unsubscribe from push notifications - Users clear their browser data - Push subscription endpoints expire (common with Apple's push service) Previously only 410 was handled, causing log spam and wasted resources for stale Apple push endpoints that return 404.
✅ Deploy Preview for maisonsdoggo canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle both 404 (Not Found) and 410 (Gone) status codes when push
notifications fail. This properly removes stale subscriptions when:
Previously only 410 was handled, causing log spam and wasted resources
for stale Apple push endpoints that return 404.