Open
Conversation
…on the same graph
Owner
|
Thanks for reporting the issue and providing a fix! |
Owner
|
@gohar94 I made a clone of your repo and used some test data and I think it's still broken. My data contains write data that individually scales to microseconds(us) and read data that scales to milliseconds. I still get buggy graphs like this: I'll have to investigate this issue further. When both read/write data is graphed, the code has to settle on one scale and scale both read and write data accordingly, which doesn't seem to happen I guess. |
Contributor
|
The fix for scaling the y-axis should be a simple fix. Created this pull request #148 with the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When plotting read and writes together as a line graph, the y-axis scale is incorrect.
Following commands can be used to reproduce this:
Incorrect:
Correct:
When plotting reads and writes separately, the output is correct. When plotting them together, the y-axis scale is incorrect.