Skip to content

Backport cryptolib commits to earlgrey 1.0.0 #28983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
h-filali wants to merge 19 commits into
base: earlgrey_1.0.0
Choose a base branch
from
Open

Backport cryptolib commits to earlgrey 1.0.0 #28983

h-filali wants to merge 19 commits into from
+4,698 −246

Conversation

@h-filali
Copy link
Contributor

@h-filali h-filali commented Dec 22, 2025 •
edited
Loading

This PR is a backport of my most recent commits to earlgrey1.0.0.

The automatic backport failed because earlgrey1.0.0 doesn't have otcrypto_interface.c.

The commits stem from the following PRs: #28926 #28724

h-filali and others added 19 commits December 22, 2025 16:50
@h-filali
[sw,cryptolib] P384 add option to input k to the sign algorithm
98707e1 
This commit adds a new sign routine to the otbn assembly that
allows for a configurable k.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 6fd0f86)
@h-filali
[sw,cryptolib] P256 make k configurable for the sign algorithm
b01d683 
This commit makes it possible to have a deterministic secret scalar k
as the input of the sign algorithm. This should only be used for
testing purposes. Depending on the selected mode, k is loaded from
the input buffer in the OTBN assembly.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 963c679)
@h-filali
[sw,cryptolib] Add KAT for P256 sign algorithm
9b5c88b 
This commit adds the possibility to set the secret scalar k for
testing purposes. This should never be used for anything but KATs.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 6b80e91)
@h-filali
[sw,cryptolib] Add KAT for P384 sign
a38e399 
This commit adds the possibility to configure the secret scalar k
for testing purposes. This functionality should never be used except
for testing purposes.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit a63689c)
@h-filali
[crypto] Add a helper for Ed25519 point decoding.
d688b24 
This function duplicates most of its code from fe_inv.

Signed-off-by: Jade Philipoom <jadep@google.com>
(cherry picked from commit 74c1ca0)
(cherry picked from commit 546fc8d)
@h-filali
[crypto] Add Ed25519 point encode/decode operations and tests.
09a5c3a 
An important decision here is how, in the decode operation, to determine
if an encoded point is valid. Details are in the comment at the top of
ed25519.s, but I have chosen here to use the ZIP15 validation criteria
to maximize predictability and compatibility.

Signed-off-by: Jade Philipoom <jadep@google.com>
(cherry picked from commit afeded2)
(cherry picked from commit 3727883)
@h-filali
[crypto] Add Ed25519 point/scalar multiplication and tests.
44cd1d6 
Scalar multiplication is fairly straightforwardly based on point
addition, using a constant-time double-and-add algorithm. Also slightly
simplify the setup for field arithmetic constants.

Signed-off-by: Jade Philipoom <jadep@google.com>
(cherry picked from commit df440d6)
(cherry picked from commit 801e601)
@h-filali
[crypto] Ed25519 signature verification implementation + test.
4f0955c 
Adds an OTBN implementation of Ed25519 signature verification (minus
some hashing that will probably be done on Ibex) and adds a single test
from the RFC as a basic validation.

Signed-off-by: Jade Philipoom <jadep@google.com>
(cherry picked from commit 971942b)
(cherry picked from commit cc13757)
@h-filali
[crypto] Ed25519 signature generation + test.
b87ba7f 
Adds an implementation of Ed25519 signature generation (in two stages to
accomodate possibly hashing on Ibex) and a single validation test from
the RFC.

Signed-off-by: Jade Philipoom <jadep@google.com>
(cherry picked from commit de2345a)
(cherry picked from commit a09e5b5)
@h-filali
[sw,cryptolib] Move ed25519 tests into test folder
6194cde 
This commit moves the tests into the correct folder and
makes any necessary changes to get the tests to run/pass.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit dc7854a)
@h-filali
[sw,cryptolib] Move globl vars to the top of the file
14d5ec7 
Helps to get a quicker overview of all the functions in
the file.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit d12cd48)
@h-filali
[sw,ed25519] Use correct registers for constants
d278d8e 
The registers for the constants d and 38 were not consistent and were
the cause for some wrong results when I ran some test vectors.

This commit fixes this issue.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit c8e2048)
@h-filali
[sw,otbn] Add run file for ed25519
be7046f 
This commit adds a file to allow the api to run the different
algorithms of ed25519.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 0243ec4)
@h-filali
[sw,ed25519] Add OTBN interface functions
171b4e7 
This commit adds the OTBN interface functions needed for
the ed25519 API.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 4f12a1f)
@h-filali
[sw,ed25519] Implement API for ed25519 sign and verify.
1fd5696 
This commit adds the code for the API for ed25519 sign
and verify. This commit stitches together the OTBN functions
and HMAC hash operations to get full fletched ed25519
sign and verify implementations.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 5501e2d)
@h-filali
[sw,otbn] Add ed25519 keygen
2359aaf 
This commit adds the ed25519 keygen function and
reuses it for the public key derivation in the sign
algorithm.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 364d85b)
@h-filali
[sw,ed25519] Add ed25519 keygen to the OTBN interface
3316532 
This commit adds the new keygen function to the OTBN
interface such that it can be used by the API.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit c233adc)
@h-filali
[sw,ed25519] Add ed25519 keygen to the ed25519 API
d740113 
This commit adds the new keygen function to the API.
The secret key is used as an input and used to
generate the public key.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 84996f3)
@h-filali
[sw,ed25519] Add ed25519 functest
f0bc086 
This commit adds an ed25519 functest which does a KAT
smoke test on the keygen, sign and verify algorithms.

Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
(cherry picked from commit 7a50802)
@h-filali h-filali requested a review from nasahlpa December 22, 2025 16:04
@h-filali h-filali requested a review from a team as a code owner December 22, 2025 16:04
@h-filali h-filali requested review from moidx and removed request for a team December 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nasahlpa nasahlpa nasahlpa approved these changes

@moidx moidx Awaiting requested review from moidx moidx is a code owner automatically assigned from lowRISC/ot-c-cpp-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-filali @nasahlpa