Heartbleed demo LCD fixes + CI check #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
force-pushed
the
heartbleed_fixes
branch
5 times, most recently
from
aea9683 to
d732357
Compare
marnovandermaas
approved these changes
May 21, 2025
Contributor
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
This looks good to me, and I can see it successfully building in this CI run: https://github.com/lowRISC/sonata-software/actions/runs/15165211539/job/42641098633
(subsequent runs use the cached result).
AlexJones0
force-pushed
the
heartbleed_fixes
branch
from
d732357 to
eada017
Compare
While the legacy automotive component was updated and the other demos were updated, the legacy Heartbleed demo was only partially updated - but the demo was failing to build. This was not caught in CI due to the fact that, unlike the legacy automotive demo, the legacy heartbleed demo build is not yet included in CI at the moment. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
This font was included for the Heartbleed demo but now exists in upstream `display_drivers`, so remove these duplicated definitions. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
heartbleed_fixes
branch
from
eada017 to
ced04cf
Compare
The CHERIoT demo starts with a grey rectangle for the response, the legacy version does not. Correct the difference by adding the rectangle to the legacy demo component on startup. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
Unlike the automotive demo's legacy component, the heartbleed demo's legacy component had not been added to the Nix flake and the corresponding CI .yml file, meaning that regressions in the ability to build the software were not being caught. Add this so that future breakages to the demo will also cause CI errors. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
As an example of how to make a firmware build with debug symbols and -O0, the heartbleed demo legacy component serves as a nice example case. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
heartbleed_fixes
branch
from
ef52bbf to
6b9ec93
Compare
engdoreis
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heartbleed demo legacy build wasn't running in CI - allowing a regression when the recent display driver changes were merged.
This PR: