fix: simplify Match exec to avoid zsh completion parsing issues#54
Merged
Conversation
Remove complex quoting from Match exec directive that was causing zsh completion to fail with "unmatched '" error. Changed from: Match host * exec "sh -c 'test -z \"$SSH_CONNECTION\"'" To: Match host * exec "test -z $SSH_CONNECTION" The simpler form works correctly: - SSH_CONNECTION unset → uses 1Password IdentityAgent - SSH_CONNECTION set → skips IdentityAgent, uses forwarded agent And avoids breaking zsh's SSH host completion which parses the config file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify Match exec quoting to fix zsh completion parsing error
Problem
The complex quoting in the Match exec directive was breaking zsh's SSH host completion:
The issue occurred because zsh's SSH completion system parses ~/.ssh/config to extract hostnames, and it couldn't handle the nested quotes in:
Solution
Simplify to direct test command without sh -c wrapper:
This simpler form:
ssh -G)Behavior
Fixes the zsh completion error while maintaining agent forwarding functionality.