Update module system to use ES modules and bundle with webpack#1
Open
krvajal wants to merge 1 commit intolozdan:masterfrom
Open
Update module system to use ES modules and bundle with webpack#1krvajal wants to merge 1 commit intolozdan:masterfrom
krvajal wants to merge 1 commit intolozdan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, nice job with the game. It's a good starter.
Using require js is a bit cumbersome and does not allow to certain things that would be nice to have. For this game, it is not that important, but in general, you will find that using requirejs for writing browser code is not a good idea though.
This is a very basic webpack implementation, not optimized at all but at least gets you working with a better build system.