single header include and compile flag for http #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the example http_client.cpp shows to include the headers in following order: ``` "../src/netlib.hpp" "../src/http/client.hpp" "../src/http/http.hpp" ``` However, a common setting in auto-formatters like clang-format will sort the headers in alphabetical order (which is also a requirement in some code-styles), like this: ``` "../src/http/client.hpp" "../src/http/http.hpp" "../src/netlib.hpp" ``` But this will lead to compilation errors as `netlib.hpp` includes headers that are needed by `client.hpp`, for example `<future>` but also library-defined symbols like `DEFAULT_TIMEOUT` or `TICK_TIME`, which are then included or defined after `client.hpp` needs them. The ordering of includes of all needed library-headers should not matter, but a single header file to include everything would be preferable anyway. To exclude features like HTTP by default anyway, a compile switch is added.
maj0ran
force-pushed
the
single_header_include
branch
from
d0c574c to
7b37e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the example http_client.cpp shows to include the headers in following order:
However, a common setting in auto-formatters like clang-format will sort the headers in alphabetical order (which is also a requirement in some code-styles), like this:
But this will lead to compilation errors as
netlib.hppincludes headers that are needed byclient.hpp, for example<future>but also library-defined symbols likeDEFAULT_TIMEOUTorTICK_TIME, which are then included or defined afterclient.hppneeds them.The ordering of includes of all needed library-headers should not matter, but a single header file to include everything would be preferable anyway. To exclude features like HTTP by default anyway, a compile switch is added.