Skip to content

Conversation

@rradczewski
Copy link
Contributor

TL;DR: Changes "tests" to "passed" to explain that the number represents the number of passed tests, not overall tests.

I know this is an incredible nitpick, but I'm using the human-readable output of gleeunit to verify that my starter project still works correctly. For v1.4.0 (v1.3.1...v1.4.0), the output changed from counting the total number of tests to counting the number of passed tests:

Example:

https://github.com/rradczewski/kata-bootstraps/blob/main/gleam/test/bootstrap_test.gleam with gleeunit 1.3.1:

...
Failures:

  1) bootstrap_test.failing_test
     Values were not equal
     expected: True
          got: False
     output: 

Finished in 0.010 seconds
2 tests, 1 failures

With gleeunit 1.4.0 and later:

...
 info: 
False
should equal
True

1 tests, 1 failures

The old implementation was here:

Text = io_lib:format("~p tests, ~p failures~ts~ts~n", [Total, Fail, SkipText, CancelText]),

For reference, here's an overview of other testrunners and how their human-readable report looks like: https://github.com/search?q=repo%3Arradczewski%2Fkata-bootstraps+%22failingTestVerification%22&type=code

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thank you for this fix!

@lpil lpil merged commit 800b2d2 into lpil:main Aug 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants