Nitpick: Clarify that number reported is number of passed tests, not total tests #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Changes "tests" to "passed" to explain that the number represents the number of passed tests, not overall tests.
I know this is an incredible nitpick, but I'm using the human-readable output of gleeunit to verify that my starter project still works correctly. For v1.4.0 (v1.3.1...v1.4.0), the output changed from counting the total number of tests to counting the number of passed tests:
Example:
https://github.com/rradczewski/kata-bootstraps/blob/main/gleam/test/bootstrap_test.gleam with gleeunit 1.3.1:
With gleeunit 1.4.0 and later:
The old implementation was here:
gleeunit/src/gleeunit_progress.erl
Line 427 in dee7bf6
For reference, here's an overview of other testrunners and how their human-readable report looks like: https://github.com/search?q=repo%3Arradczewski%2Fkata-bootstraps+%22failingTestVerification%22&type=code