Skip to content

Create new array shuffled flow based on the Refinery #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lscharmer wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

Create new array shuffled flow based on the Refinery #2

lscharmer wants to merge 10 commits into from

Conversation

@lscharmer
Copy link
Owner

@lscharmer lscharmer commented Nov 11, 2021

The new implementation uses the shuffle(...) function instead of the ilArrayElementShuffler::mtShuffle(...) method because since PHP 7.1 shuffle() already uses the Mersenne Twister algorithm. (see https://www.php.net/manual/en/function.shuffle.php)

The existence check for mt_srand and mt_rand is also removed, because it is replaced by srand in PHP 7.1 (see https://www.php.net/manual/en/function.mt-srand.php)

mjansenDatabay
mjansenDatabay reviewed Nov 12, 2021
View reviewed changes
@lscharmer lscharmer force-pushed the feature/refinery-random-v2 branch from 05eef20 to 92c02e2 Compare December 3, 2021 10:51
daniwe4 and others added 10 commits December 6, 2021 14:34
@klees klees force-pushed the feature/refinery-random-v2 branch from 92c02e2 to 3327f42 Compare December 6, 2021 16:06
lscharmer pushed a commit that referenced this pull request Jan 5, 2022
@iomidev
Merge pull request #2 from kroepelin-projekte/code_review
b2c668f 
Pull Request for Code Review
lscharmer pushed a commit that referenced this pull request Mar 31, 2022
@fwolf-ilias
Update ilias_ja.lang #2 - by Shiro Tamoto
159e449
lscharmer pushed a commit that referenced this pull request May 31, 2022
ilStaticCache::set() must return bool
4bfcd46 
Hi Fabian,

a PHP Fatal Error occurs when performing setup command 'migrate':

PHP Fatal error:  Uncaught ILIAS\Setup\UnachievableException: Problem in DB-Update: 0 Return value of ilStaticCache::set() must be of the type bool, array returned in /***/trunk8/Services/GlobalCache/classes/Static/class.ilStaticCache.php:33#0 /***/trunk8/Services/GlobalCache/classes/class.ilGlobalCache.php(307): ilStaticCache->set()
#1 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(62): ilGlobalCache->set()
#2 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(29): ilCachedLanguage->writeToCache()
#3 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(107): ilCachedLanguage->__construct()
#4 /***/trunk8/Services/Language/classes/class.ilLanguage.php(91): ilCachedLanguage::getInstance()
#5 /***/trunk8/Services/Language/classes/class.ilLanguage.php(374): ilLanguage->__construct in /***/trunk8/Services/Database/classes/Setup/class.ilDatabaseUpdatedObjective.php on line 72
lscharmer pushed a commit that referenced this pull request Jun 28, 2022
@smeyer-ilias
0033045: Pre8: Wiki > Settings > Rechteeinstellungen: "ilRbacReview::…
39d2f7e 
…getActiveOperationsOfRole(): Argument #2 ($a_role_id) must be of …"
lscharmer pushed a commit that referenced this pull request Jun 28, 2022
@smeyer-ilias
0033081: Pre8: Wiki Permission settings "ilRadioOption::__construct()…
77032fa 
…: Argument #2 ($a_value) must be of type string…"
lscharmer pushed a commit that referenced this pull request Jul 18, 2022
@alex40724
33247: Pre8: Exporting users in XML: ilUserXMLWriter::__addElement():…
8242385 
… Argument #2 () must be of type string, null given
lscharmer pushed a commit that referenced this pull request Aug 10, 2022
@mbecker-databay
33483: Pre8: Creation of MC question fails with "ASS_AnswerMultipleRe…
2a22010 
…sponseImage::__construct(): Argument #2 ($points) must be…"
lscharmer pushed a commit that referenced this pull request Nov 28, 2022
@tfamula
Refactor deprecated update steps using Objectives #2
3339b92
lscharmer pushed a commit that referenced this pull request Jan 13, 2023
@tfamula
Refactor deprecated update steps using Objectives #2
e66cb9e
lscharmer pushed a commit that referenced this pull request Feb 6, 2023
@mbecker-databay
ilObjTaxonomy::cloneNodes(): Argument #2 ($a_target_parent) must be o…
2400d3f 
…f type int, string given
lscharmer pushed a commit that referenced this pull request Feb 24, 2023
@mbecker-databay
ilObjTaxonomy::cloneNodes(): Argument #2 ($a_target_parent) must be o…
8d036a7 
…f type int, string given
lscharmer pushed a commit that referenced this pull request Aug 2, 2023
@fhelfer
review dashboard #2
1a3ec9d
lscharmer pushed a commit that referenced this pull request Aug 2, 2023
@catkrahl @catenglaender
mode info: adjusted unit test #2
90d0125
lscharmer pushed a commit that referenced this pull request Nov 3, 2023
@alex40724
38230: explode(): Passing null to parameter #2 () of type string is d…
52e2169 
…eprecated
lscharmer pushed a commit that referenced this pull request Nov 3, 2023
@alex40724
38230: explode(): Passing null to parameter #2 () of type string is d…
3c9495e 
…eprecated
lscharmer pushed a commit that referenced this pull request Jun 11, 2024
@alex40724
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (ILIAS-eLearning…
958f5ee 
…#7410)

TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer pushed a commit that referenced this pull request Jun 24, 2024
@eozkeskin
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (ILIAS-eLearning…
31a934a 
…#7410)

TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer pushed a commit that referenced this pull request Jun 24, 2024
@alex40724
Fix: Type error. ilObjSurvey::getAnonymousIdByCode() (ILIAS-eLearning…
b5648ea 
…#7410)

TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned"

Stacktrace:
ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702
ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175
ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354
ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280
#5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140
#4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206
#2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199
#1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174
#0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer pushed a commit that referenced this pull request Jun 24, 2024
@alex40724
41292: Change Comments in ILIAS LM : explode(): Passing null to param…
332824c 
…eter #2 () of type string is deprecated
lscharmer pushed a commit that referenced this pull request Aug 9, 2024
@mjansenDatabay @thojou
Test: Fix ilUserCertificateRepository::__construct(): Argument #2 ($l…
94efaee 
…ogger) must be of type ?ilLogger

Mantis: https://mantis.ilias.de/view.php?id=41662
lscharmer pushed a commit that referenced this pull request Aug 15, 2024
@mjansenDatabay @thojou
Test: Fix ilUserCertificateRepository::__construct(): Argument #2 ($l…
f26a91e 
…ogger) must be of type ?ilLogger

Mantis: https://mantis.ilias.de/view.php?id=41662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjansenDatabay mjansenDatabay mjansenDatabay left review comments

Assignees

@mjansenDatabay mjansenDatabay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lscharmer @mjansenDatabay @daniwe4 @matthiaskunkel @klees