PHP 8: Code Review Services/Skill
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lscharmer
force-pushed
the
php8-services-skill-review
branch
from
c25d98d to
c20c99f
Compare
lscharmer
force-pushed
the
php8-services-skill-review
branch
from
c20c99f to
0e3d2a2
Compare
lscharmer
pushed a commit
that referenced
this pull request
May 31, 2022
Hi Fabian, a PHP Fatal Error occurs when performing setup command 'migrate': PHP Fatal error: Uncaught ILIAS\Setup\UnachievableException: Problem in DB-Update: 0 Return value of ilStaticCache::set() must be of the type bool, array returned in /***/trunk8/Services/GlobalCache/classes/Static/class.ilStaticCache.php:33#0 /***/trunk8/Services/GlobalCache/classes/class.ilGlobalCache.php(307): ilStaticCache->set() #1 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(62): ilGlobalCache->set() #2 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(29): ilCachedLanguage->writeToCache() #3 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(107): ilCachedLanguage->__construct() #4 /***/trunk8/Services/Language/classes/class.ilLanguage.php(91): ilCachedLanguage::getInstance() #5 /***/trunk8/Services/Language/classes/class.ilLanguage.php(374): ilLanguage->__construct in /***/trunk8/Services/Database/classes/Setup/class.ilDatabaseUpdatedObjective.php on line 72
lscharmer
pushed a commit
that referenced
this pull request
Jun 28, 2022
…ldFullPeriodData(): Argument #4 () must be…
lscharmer
pushed a commit
that referenced
this pull request
Jul 18, 2022
…ment #4 ($passed) must be of type int, null given"
lscharmer
pushed a commit
that referenced
this pull request
Aug 2, 2023
lscharmer
pushed a commit
that referenced
this pull request
Aug 2, 2023
lscharmer
pushed a commit
that referenced
this pull request
Jun 11, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer
pushed a commit
that referenced
this pull request
Jun 24, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer
pushed a commit
that referenced
this pull request
Jun 24, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kannst du folgendes nochmal absegnen / double checken?
getUsageInfo* Referenz zu return Wert
getUsageInfo*wurden von references auf arrays umgebaut. Meinen "Berechnungen" nach passt das daher mitarray_merge_recursively:Services/Skill/classes/class.ilSkillUsage.php:181:hier wird es verwendetAlle anderen Stellen dazu:
Services/Skill/interfaces/interface.ilSkillUsageInfo.php:35:Services/Skill/Resources/class.ilSkillResources.php:184:Services/Skill/Profile/class.ilSkillProfile.php:765:Services/Skill/classes/class.ilSkillUsage.php:119:Services/Skill/classes/class.ilSkillUsage.php:135:Services/Skill/classes/class.ilPersonalSkill.php:294:Services/Skill/classes/class.ilBasicSkill.php:546:Unnötiges array_column
array_mapbehält die keys bereits bei, daher ist dasarray_columnunnötig und(int)cast und(bool)cast wurden durchintvalundboolvalersetzt:Services/Skill/Service/classes/class.SkillGUIRequest.php:75:Services/Skill/Service/classes/class.SkillGUIRequest.php:102:Services/Skill/Service/classes/class.SkillGUIRequest.php:134:Umbau von
max(...)Die keys von
$childssind numerisch, sollte daher kein Problem sein:Services/Skill/Tree/class.ilSkillTree.php:118: