DM-52542: Reduce storage and transmission size of historical channel table data#293
Open
ugyballoons wants to merge 21 commits intodevelopfrom
Open
DM-52542: Reduce storage and transmission size of historical channel table data#293ugyballoons wants to merge 21 commits intodevelopfrom
ugyballoons wants to merge 21 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes storage and transmission of historical channel table data by replacing full bucket key storage with a structured format storing only sequence numbers and file extensions. Instead of downloading all metadata files upfront, metadata is now retrieved on-demand when requested by clients.
Key changes:
- Introduced structured data storage format using sequence numbers and extension patterns
- Implemented extension deduplication strategy with default extensions and exceptions
- Moved metadata retrieval from polling to on-demand fetching
- Added client-side reconstruction of table data from structured format
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| python/lsst/ts/rubintv/background/historicaldata.py | Core implementation of structured event storage and extension optimization |
| python/lsst/ts/rubintv/models/models.py | New data structures for structured data, extension info, and specialized page data classes |
| python/lsst/ts/rubintv/handlers/api.py | Updated API endpoint to return structured data and fetch metadata on-demand |
| src/js/modules/convertTableData.ts | Client-side conversion of structured data back to table format |
| src/js/components/TableApp.tsx | Integration of client-side table reconstruction |
| tests/background/historicaldata_test.py | Comprehensive test suite for new structured storage |
| tests/models/dataclass_test.py | Tests for new dataclass structures |
| src/js/modules/tests/convertTableData.test.js | Client-side conversion tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
518067a to
34a5b20
Compare
Add missing datestart and end attributes
4c4c8ab to
aa2716e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of saving objects or strings that contain the whole bucket keys for individual files and downloading every metadata file wholesale, store the sequence numbers and extensions in a way that can be sent over websocket and recreated in the client and donwnload historical metadata when requested.
This should both speed up the historical data polling task and the reduce the size of the transfer of data via websocket.