Skip to content

Comments

DM-53068: Accept seqNum range in URL and add date related UI functionality#294

Open
ugyballoons wants to merge 22 commits intodevelopfrom
tickets/DM-53068
Open

DM-53068: Accept seqNum range in URL and add date related UI functionality#294
ugyballoons wants to merge 22 commits intodevelopfrom
tickets/DM-53068

Conversation

@ugyballoons
Copy link
Collaborator

@ugyballoons ugyballoons commented Nov 5, 2025

Individual seqNums and seqNum ranges can be specified via URL e.g.:
rubintv/test/lsstcam/date/2025-10-20?seq_num=60,85 or rubintv/test/lsstcam/date/2025-10-20?seq_num=72
The calendar now only shows when the date is clicked on.
The next/previous historical days can be jumped to using the buttons either side of the date.

@ugyballoons ugyballoons requested a review from Copilot November 5, 2025 13:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the camera table page to improve code organization and add new features including date navigation, sequence number highlighting, and calendar updates. The changes consolidate multiple React components into a single unified CameraTable component and extract reusable functionality.

  • Consolidates page rendering logic into a new CameraTable component
  • Adds date navigation buttons with prev/next functionality
  • Implements sequence number highlighting and auto-scroll
  • Extracts useModal hook and Button component for reuse
  • Refactors websocket notification system for better maintainability

Reviewed Changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/js/components/CameraTable.tsx New unified component that orchestrates calendar, channels, and table rendering
src/js/components/TableView.tsx Adds sequence number highlighting and auto-scroll functionality
src/js/components/TableControls.tsx Implements date navigation buttons and calendar toggle
src/js/hooks/useModal.tsx Extracts modal hook for reusability across components
src/js/components/Button.tsx Extracts button component from PerDay
src/js/modules/utils.ts Adds utility functions for date navigation and sequence ranges
src/sass/style.sass Updates styles for date navigation UI and row highlighting
python/lsst/ts/rubintv/handlers/pages.py Adds seq_num parameter support and calendar data retrieval
python/lsst/ts/rubintv/background/historicaldata.py Adds calendar update notifications
eslint.config.mjs Simplifies ESLint configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant