DM-53068: Accept seqNum range in URL and add date related UI functionality#294
Open
ugyballoons wants to merge 22 commits intodevelopfrom
Open
DM-53068: Accept seqNum range in URL and add date related UI functionality#294ugyballoons wants to merge 22 commits intodevelopfrom
ugyballoons wants to merge 22 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the camera table page to improve code organization and add new features including date navigation, sequence number highlighting, and calendar updates. The changes consolidate multiple React components into a single unified CameraTable component and extract reusable functionality.
- Consolidates page rendering logic into a new
CameraTablecomponent - Adds date navigation buttons with prev/next functionality
- Implements sequence number highlighting and auto-scroll
- Extracts
useModalhook andButtoncomponent for reuse - Refactors websocket notification system for better maintainability
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/js/components/CameraTable.tsx | New unified component that orchestrates calendar, channels, and table rendering |
| src/js/components/TableView.tsx | Adds sequence number highlighting and auto-scroll functionality |
| src/js/components/TableControls.tsx | Implements date navigation buttons and calendar toggle |
| src/js/hooks/useModal.tsx | Extracts modal hook for reusability across components |
| src/js/components/Button.tsx | Extracts button component from PerDay |
| src/js/modules/utils.ts | Adds utility functions for date navigation and sequence ranges |
| src/sass/style.sass | Updates styles for date navigation UI and row highlighting |
| python/lsst/ts/rubintv/handlers/pages.py | Adds seq_num parameter support and calendar data retrieval |
| python/lsst/ts/rubintv/background/historicaldata.py | Adds calendar update notifications |
| eslint.config.mjs | Simplifies ESLint configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
be7e6e9 to
77fce3c
Compare
14b6923 to
0502db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual seqNums and seqNum ranges can be specified via URL e.g.:
rubintv/test/lsstcam/date/2025-10-20?seq_num=60,85 or rubintv/test/lsstcam/date/2025-10-20?seq_num=72
The calendar now only shows when the date is clicked on.
The next/previous historical days can be jumped to using the buttons either side of the date.