SITCOM-2316: Fix bugs related to workspace creation from json#28
Open
ugyballoons wants to merge 6 commits intomainfrom
Open
SITCOM-2316: Fix bugs related to workspace creation from json#28ugyballoons wants to merge 6 commits intomainfrom
ugyballoons wants to merge 6 commits intomainfrom
Conversation
Also add copious debug logs.
- Fix workspace clearing to properly unsubscribe blocs before closing - Add proper async/await handling in workspace loading to prevent emit-after-completion errors - Fix memory leaks by cancelling subscriptions in FocalPlaneChartBloc.close() - Use stable ID for WorkspaceViewer selection subscription and add dispose cleanup - Add extensive logging throughout workspace load/clear cycle for debugging - Improve error handling and reporting during workspace deserialization - Add schema field validation with user-friendly error messages - Fix workspace rebuild logic to avoid unnecessary rebuilds during data loading
ugyballoons
force-pushed
the
tickets/SITCOM-2316
branch
from
c112e4c to
0a85533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Loading from JSON twice is leaving the workspace in a non-consistant state.
This PR aims to fix the issues by making sure that workspaces are properly cleared before loading anew. This also involves making sure that discarded charts are unsubscribed from the selection controller and that new ones are consistantly subscribed.