Build warnings #88
Merged
Build warnings #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This builds on top of #85 |
tmccombs
force-pushed
the
build-warnings
branch
from
6503c49 to
f68bd5b
Compare
tmccombs
force-pushed
the
build-warnings
branch
from
f68bd5b to
7df0148
Compare
Fix all warnings and enable fatal warnings. Also remove the dependency on scala-compat. This is mostly backwards compatible, but won't work with versions of scala before 2.13. It also adds an implicit conversion from SqlRow => A to RowParser[A], which allows continuing to pass in a function as the argument instead of an implicit RowParser, but might be subtly different in some cases.
tmccombs
force-pushed
the
build-warnings
branch
from
7df0148 to
7005688
Compare
coreywoodfield
approved these changes
Feb 3, 2025
| def asCollection[U, T[_]](parser: SqlRow => U)(implicit factory: Factory[U, T[U]], connection: Connection): T[U] = | ||
| normalStatement.execute(_.asCollection(parser)) | ||
| def asCollection[U: RowParser, T[_]]()(implicit factory: Factory[U, T[U]], connection: Connection): T[U] = | ||
| // def asCollection[U, T[_]](parser: SqlRow => U)(implicit factory: Factory[U, T[U]], connection: Connection): T[U] = |
Contributor
There was a problem hiding this comment.
Why leave these commented out? why not just delete them?
sriraamas
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.