V4.0.9 #1
Open
V4.0.9 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BitBox02 v9.2.0: support for signing messages and for p2wsh-p2sh legacy multisig accounts
As these pkgs are often provided by the OS package manager (e.g. apt), the version limits specified in requirements*.txt and setup.py will never get applied.
until tartley/colorama#284 is resolved colorama 0.4.4 does not have a source dist uploaded to PyPI, which breaks contrib/make_packages this partially reverts 4d0afff
For an action called "Cancel transaction" it is confusing to have a "Cancel" button that cancels the action... not sure how to fix -- this is perhaps the least intrusive change
electrs sends fee histogram with float feerates
sys.ps1 and sys.ps2 define the strings used as primary and secondary prompts in the Python interpreter. Also fix a rare bug introduced by myself in 7772af6 (#6607) where spaces at the end of the current line would not be remembered when switching server.
Previously we would only show input amounts for partial txs. Now also show them for complete txs as well, if we know them: we check in the wallet db for the prevtx and read the value for the output. This is safe as the input commits to the prevout via txid (which commits to the output value). Also show "from addresses" in more cases in a similar fashion.
some years ago wallet.get_tx_delta returned Optional[int] but it returns int now
Re the check at the end: "history not synchronized" - it's not that it's not synchronized, rather that the history is changing while being computed.
```
File "/home/user/venvs/electrum37/lib64/python3.7/site-packages/kivy/lang/builder.py", line 654, in _apply_rule
child = cls(__no_builder=True)
TypeError: __init__() got an unexpected keyword argument '__no_builder'
```
follow-up c704844
related: #6669 (note that instructions assume this commit as otherwise AUTOCONF_FLAGS is overwritten!) based on https://stackoverflow.com/a/17748092
So that I don't have to figure out every time.
Enables lightning by creating a node private key and storing it in the wallet. The gossiper is not launched at start up, only if there are existing channels.
The gossip db is loaded early when the network is started to save time when the gui is locked and a wallet not yet loaded. Side effects of the LNWallet to start peering when a channel db is loaded is circumvented.
build: don't allow setuptools to sneakily install build-time deps
as discussed in issue #6697, users with large wallets or slow connections may never see their initial request-missing-tx run complete, if we always use the same sync order. This commit shuffles the addresses being requested every time a new request round happens, so that (if enough time passes and enough initial state requests are attempted) we will always get the latest state for each address, regardless of how quickly the connection times out on us
and show toast msg when opening "channels" dialog if lightning is not available for wallet
In a normal (forward) swap (onchain->offchain): send_amount = receive_amount * (1 + service_percentage) + normal_fee , and vice versa: receive_amount = (send_amount + normal_fee) / (1 + service_percentage) , i.e., the service fee is charged on the received offchain amount.
Swap improvements
The 'height' field was added in spesmilo/electrum@cdfaaa2 At the time we thought we could just add it with a default value without a db upgrade; however the issue is that if old code tries to open a new db, it will fail (due to unexpected new field). Hence it is better to do an explicit conversion where old code *knows* it cannot open the new db. E | gui.qt.ElectrumGui | Traceback (most recent call last): File "...\electrum\electrum\gui\qt\__init__.py", line 257, in start_new_window wallet = self.daemon.load_wallet(path, None) File "...\electrum\electrum\daemon.py", line 488, in load_wallet db = WalletDB(storage.read(), manual_upgrades=manual_upgrades) File "...\electrum\electrum\wallet_db.py", line 72, in __init__ self.load_data(raw) File "...\electrum\electrum\wallet_db.py", line 103, in load_data self._after_upgrade_tasks() File "...\electrum\electrum\wallet_db.py", line 189, in _after_upgrade_tasks self._load_transactions() File "...\electrum\electrum\util.py", line 408, in <lambda> return lambda *args, **kw_args: do_profile(args, kw_args) File "...\electrum\electrum\util.py", line 404, in do_profile o = func(*args, **kw_args) File "...\electrum\electrum\wallet_db.py", line 1139, in _load_transactions self.data = StoredDict(self.data, self, []) File "...\electrum\electrum\json_db.py", line 79, in __init__ self.__setitem__(k, v) File "...\electrum\electrum\json_db.py", line 44, in wrapper return func(self, *args, **kwargs) File "...\electrum\electrum\json_db.py", line 105, in __setitem__ v = self.db._convert_dict(self.path, key, v) File "...\electrum\electrum\wallet_db.py", line 1182, in _convert_dict v = dict((k, Invoice.from_json(x)) for k, x in v.items()) File "...\electrum\electrum\wallet_db.py", line 1182, in <genexpr> v = dict((k, Invoice.from_json(x)) for k, x in v.items()) File "...\electrum\electrum\invoices.py", line 108, in from_json return OnchainInvoice(**x) TypeError: __init__() got an unexpected keyword argument 'height'
wallet_db: impl convert_version_33: put 'height' field into invoices
in the num_sats_can_send/receive methods of the lnwallet.
lnchannel: reflect frozen amounts and disconnected peers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.