Avoid single line if statements#134
Open
aelkazdadi wants to merge 1 commit intoluochen1990:masterfrom
Open
Conversation
|
Thanks, this addressed an issue I had trying to use the plugin in neovim. Changing to your branch with this change fixed the issue. |
Contributor
|
Maybe it's better to use diff --git a/autoload/rainbow.vim b/autoload/rainbow.vim
index 10551c5..8f870e0 100644
--- a/autoload/rainbow.vim
+++ b/autoload/rainbow.vim
@@ -79,7 +79,9 @@ fun rainbow#syn(config)
exe 'syn cluster '.prefix.'Regions contains='.join(map(range(cycle), '"@".s:synGroupID(prefix, "Regions", v:val)'), ',')
exe 'syn cluster '.prefix.'Parentheses contains='.join(map(range(cycle), '"@".s:synGroupID(prefix, "Parentheses", v:val)'), ',')
exe 'syn cluster '.prefix.'Operators contains='.join(map(range(cycle), '"@".s:synGroupID(prefix, "Operators", v:val)'), ',')
- if has_key(conf, 'after') | for cmd in conf.after | exe cmd | endfor | endif
+ for cmd in get(conf, 'after', [])
+ exe cmd
+ endfor
endfun
fun rainbow#syn_clear(config) |
Owner
|
I want to merge this, but there is mixed indent in this PR... Maybe this indent detect plugin will help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug with vim (neovim?) where inline
if cond | return | endifstyle commands can result in errors such as this one.This can be reproduced by opening neovim and pressing
:%s/<C-f>.Replacing the inline if statements with multiple line ones fixes the issue.