Add TOSA support #1521

fresve-arm · 2025-12-04T09:01:21Z

Added support for TOSA.

See: https://www.mlplatform.org/tosa/tosa_spec.html

Added support for TOSA. Change-Id: I9db557cbee42bb3950198692cd8f2f5aab7c8c47

lutzroeder

@fresve-arm thank you for the pull request. Trying to understand why this format is needed given it is almost identical to dozens of other formats and already seems to bring versioning complexity? For example, asking an AI agent it will recommend this is a high maintenance and low value effort.

lutzroeder · 2025-12-05T15:35:46Z

source/base.js

@@ -1,3 +1,4 @@
+// SPDX-FileCopyrightText: Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>


lutzroeder · 2025-12-05T15:39:50Z

source/base.js

    return value & ((1 << bits) - 1);
 };

+DataView.prototype.getInt48 = DataView.prototype.getInt48 || function(offset, littleEndian) {


This does some heavy allocation. Robot suggested this approach:

DataView.prototype.getInt48 = DataView.prototype.getInt48 || function(offset, littleEndian) { let value; if (littleEndian) { const low = this.getUint32(offset, true); const high = this.getUint16(offset + 4, true); value = low + high * 0x100000000; } else { const high = this.getUint16(offset, false); const low = this.getUint32(offset + 2, false); value = high * 0x100000000 + low; } // Sign extension: if bit 47 is set, subtract 2^48 if (value >= 0x800000000000) { value -= 0x1000000000000; } return value; };

True, it does allocate a small buffer if there is less than 8 bytes of data available. I'll have a look at the suggested alternative approach.

lutzroeder · 2025-12-05T15:41:23Z

source/tosa-version.js

+
+export const tosa = {};
+
+tosa.Version = class Version {


Fold into tosa.js.

lutzroeder · 2025-12-05T15:41:34Z

source/tosa.js

@@ -0,0 +1,310 @@
+// SPDX-FileCopyrightText: Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>


lutzroeder · 2025-12-05T15:41:47Z

LICENSE

 MIT License

 Copyright (c) Lutz Roeder
+Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>


I understand from the rest of the codebase this is the only place with a copyright notice. I also respect that you may not want to have added copyrights to the license file. Would you consider adding an AUTHORS or CONTRIBUTORS file for listing copyrights of contributors?

The app is MIT licensed and aims to keep licensing and contribution requirements simple and consistent. For small contributions, especially those mainly serving a business need, adding copyright files introduces unnecessary complexity.

Agree that contributors should be credited. AUTHORS files have their own issues, and the current merge style isn’t ideal either. So while we look for a better long-term option, how about adding a simple // Contributed by Fredrik Svedberg to tosa.js?

lutzroeder · 2025-12-05T15:41:56Z

package.js

@@ -1,3 +1,4 @@
+// SPDX-FileCopyrightText: Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>


lutzroeder · 2025-12-05T15:42:15Z

package.js

        'tf',
        'uff',
-        'xmodel'
+        'xmodel',


Sorted alphabetically.

lutzroeder · 2025-12-05T15:49:36Z

tools/tosa

+}
+
+schema() {
+    for TOSA_VERSION in ${TOSA_VERSIONS[@]}


There should be a single tosa-schema.js and tosa-metadata.json file. For metadata this can be accomplished by adding version tags similar to ONNX and other formats. Breaking schemas instead of incrementally versioning them tends to be a bad practice as it will make maintenance costly and breaking user expectations.

I'm willing to drop pre-1.0 support if this would ease the acceptance of this PR?
With 1.0 and forwards there should not be any breaking changes to the schema, which would reduce the need for maintenance.

Sounds good. mslite.js went through a similar cycle, e.g. copy the same approach to informing the user.

lutzroeder · 2025-12-05T15:52:00Z

tools/tosa

+    for TOSA_VERSION in ${TOSA_VERSIONS[@]}
+    do
+        bold "tosa metadata ${TOSA_VERSION}"
+        python3 ./tools/tosa_metadata.py --xml ./third_party/tosa/tosa_${TOSA_VERSION}.xml > ./source/tosa-metadata-${TOSA_VERSION}.json


Structure is third_party/source/tosa/.... When using curl folder structure should match paths in the repo in case curl later needs to be replaced with git clone.

lutzroeder · 2025-12-05T15:54:16Z

tools/tosa_metadata.py

+#!/usr/bin/env python3
+# SPDX-FileCopyrightText: Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>
+
+"""Parsing of tosa.xml to tosa_metadata.json"""


Since this doesn't have any Python specific dependencies please converted to JavaScript using ../source/xml.js.

fresve-arm · 2025-12-10T15:52:57Z

Trying to understand why this format is needed given it is almost identical to dozens of other formats and already seems to bring versioning complexity? For example, asking an AI agent it will recommend this is a high maintenance and low value effort.

Some motivation why this format was created can be found in the introduction of the specification https://www.mlplatform.org/tosa/tosa_spec_1_0_1.html#_introduction
We use this format extensively and the need for visualising graphs is needed on a daily basis. This is where Netron comes in handy! Adding official support for the format would be great and I don't expect the maintenance burden post v1.0 to be that high. Besides it's in our interest to keep maintaining the support for the format in a tool we already use a lot.

Add TOSA support

fee0ab6

Added support for TOSA. Change-Id: I9db557cbee42bb3950198692cd8f2f5aab7c8c47

lutzroeder force-pushed the main branch 2 times, most recently from 115d90e to 13c0251 Compare December 5, 2025 03:33

lutzroeder requested changes Dec 5, 2025

View reviewed changes

lutzroeder force-pushed the main branch 18 times, most recently from 396dc74 to 6c1732b Compare December 10, 2025 14:55

lutzroeder force-pushed the main branch 7 times, most recently from da94ec5 to 166f0a0 Compare December 13, 2025 20:34

lutzroeder force-pushed the main branch 30 times, most recently from c78cb29 to ec17c2e Compare January 10, 2026 04:42

		@@ -1,3 +1,4 @@
		// SPDX-FileCopyrightText: Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>

		@@ -0,0 +1,310 @@
		// SPDX-FileCopyrightText: Copyright 2025 Arm Limited and/or its affiliates <open-source-office@arm.com>

Add TOSA support #1521

Are you sure you want to change the base?

Add TOSA support #1521

Conversation

fresve-arm commented Dec 4, 2025

Uh oh!

lutzroeder left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fresve-arm Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lutzroeder Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lutzroeder Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fresve-arm commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fresve-arm Dec 10, 2025 •

edited

Loading

lutzroeder Dec 10, 2025 •

edited

Loading

lutzroeder Dec 5, 2025 •

edited

Loading