Skip to content

chore: implement GitHub Actions - Claude Code Review/Merge Review and Renovate Approval #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisleekr merged 1 commit into from
Jan 18, 2026
Merged

chore: implement GitHub Actions - Claude Code Review/Merge Review and Renovate Approval #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/claude-merge-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Claude Merge Review Workflow
#
# Triggers:
# - Automatic (enable_merge_review_always: false, default):
# - Dismisses previous approvals when new commits are pushed
# - Automatic (enable_merge_review_always: true):
# - Runs merge review when PR is marked ready for review or new commits are pushed (non-draft PRs only)
# - Assigns risk scores (1-5) based on change complexity
# - Auto-approves low-risk PRs (configurable threshold)
# - Manual: When someone comments `@claude merge review` in the PR
# - Assigns risk scores (1-5) based on change complexity
# - Auto-approves low-risk PRs (configurable threshold)

name: Claude Auto Approval Merge Review

on:
pull_request:
types: [synchronize, ready_for_review]
issue_comment:
types: [created]

concurrency:
group: claude-merge-review-${{ github.event.pull_request.number || github.event.issue.number }}
cancel-in-progress: false

jobs:
claude-merge-review:
uses: lux-group/github-actions/.github/workflows/claude-merge-review.yml@main
secrets:
AWS_ROLE_TO_ASSUME: ${{ secrets.AWS_ROLE_TO_ASSUME_GITHUB_ROLE_DEV }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Swift package repository without Node.js/NPM dependencies, but the workflow is passing NPM_TOKEN and AWS_ROLE_TO_ASSUME secrets. These secrets appear unnecessary for a Swift project. Verify that these secrets are required by the reusable workflow or remove them if they're not applicable to Swift projects.

Suggested change
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

Copilot uses AI. Check for mistakes.
CONTEXT7_API_KEY: ${{ secrets.CONTEXT7_API_KEY }}
REVIEWER_GITHUB_TOKEN: ${{ secrets.REVIEWER_GITHUB_TOKEN }}
with:
auto_approve_score: "1" # Auto-approve PRs with risk score 1 (very low risk)
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment indicates auto-approval for 'very low risk' changes, but the risk scoring system (1-5) mentioned in the file header comments isn't clearly defined. Consider adding a reference to documentation that explains what risk score 1 means and what types of changes qualify for each score level to help maintainers understand the auto-approval criteria.

Copilot uses AI. Check for mistakes.
skip_setup_node_deps: true
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter 'skip_setup_node_deps' suggests Node.js dependency setup, which is inconsistent with this Swift package repository. Verify that this parameter is necessary for the reusable workflow when used with Swift projects, or clarify why Node.js-related configuration is needed for a Swift project.

Suggested change
skip_setup_node_deps: true

Copilot uses AI. Check for mistakes.
27 changes: 27 additions & 0 deletions .github/workflows/claude-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Claude Code Review Workflow
#
# Triggers:
# - Automatic: When a PR is opened or marked as ready for review
# - Manual: When someone comments `@claude review` in the PR

name: Claude Auto Review

on:
pull_request:
types: [opened, ready_for_review]
issue_comment:
types: [created]

concurrency:
group: claude-review-${{ github.event.pull_request.number || github.event.issue.number }}
cancel-in-progress: false

jobs:
claude-review:
uses: lux-group/github-actions/.github/workflows/claude-review.yml@main
secrets:
AWS_ROLE_TO_ASSUME: ${{ secrets.AWS_ROLE_TO_ASSUME_GITHUB_ROLE_DEV }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Swift package repository without Node.js/NPM dependencies, but the workflow is passing NPM_TOKEN and AWS_ROLE_TO_ASSUME secrets. These secrets appear unnecessary for a Swift project. Verify that these secrets are required by the reusable workflow or remove them if they're not applicable to Swift projects.

Suggested change
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

Copilot uses AI. Check for mistakes.
CONTEXT7_API_KEY: ${{ secrets.CONTEXT7_API_KEY }}
with:
skip_setup_node_deps: true
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter 'skip_setup_node_deps' suggests Node.js dependency setup, which is inconsistent with this Swift package repository. Verify that this parameter is necessary for the reusable workflow when used with Swift projects, or clarify why Node.js-related configuration is needed for a Swift project.

Suggested change
skip_setup_node_deps: true

Copilot uses AI. Check for mistakes.
25 changes: 25 additions & 0 deletions .github/workflows/renovate-approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Renovate luxuryescapes-reviewer Approval Workflow
#
# Triggers on all pull_request_review events. The reusable workflow handles
# filtering (skips non-Renovate reviews). This avoids duplicating filter logic
# across caller workflows.
#
# When renovate-approve[bot] approves a Renovate PR:
# - Adds luxuryescapes-reviewer approval using REVIEWER_GITHUB_TOKEN
# - GitHub's auto-merge (enabled by Renovate) handles the rest

name: Renovate Approval

on:
pull_request_review:
types: [submitted]

concurrency:
group: renovate-approval-${{ github.event.pull_request.number }}
cancel-in-progress: true

jobs:
renovate-approval:
uses: lux-group/github-actions/.github/workflows/renovate-approval.yml@main
secrets:
REVIEWER_GITHUB_TOKEN: ${{ secrets.REVIEWER_GITHUB_TOKEN }}
Loading