Changed the existing examples who use SnapsUploder/SnapsData to use n… #808
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the codebase to use the new version of SnapData and SnapsUploader APIs from depthai-nodes. The changes refactor how snap data is created by introducing the FileGroup pattern, which encapsulates image-detection pairs before passing them to SnapData.
Changes:
- Updated SnapData instantiation to use FileGroup instead of passing frame and detections directly as separate parameters
- Updated requirements.txt files to point to the development branch of depthai-nodes that contains the new API
- Refactored two SnapsProducer implementations to adopt the new FileGroup-based API
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| integrations/hub-snaps-events/utils/snaps_producer.py | Updated to create FileGroup and use new SnapData API with file_group parameter |
| integrations/hub-snaps-events/requirements.txt | Updated depthai-nodes dependency to git branch feat/dai_dev_req |
| apps/data-collection/backend/src/core/snapping/snaps_producer.py | Updated to create FileGroup with named file and use new SnapData API |
| apps/data-collection/backend/src/requirements.txt | Updated depthai-nodes dependency to git branch feat/dai_dev_req |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #depthai-nodes==0.3.7 | ||
| depthai-nodes @ git+https://github.com/luxonis/depthai-nodes.git@feat/dai_dev_req |
There was a problem hiding this comment.
The PR description states this should be merged after the new depthai_nodes release (0.3.8), but the requirements are pointing to a git branch instead of the version number. This should be updated to use the released version once depthai-nodes 0.3.8 is published to ensure reproducible builds and proper dependency management.
| @@ -1,5 +1,5 @@ | |||
| depthai==3.2.1 | |||
| depthai-nodes==0.3.7 | |||
| depthai-nodes @ git+https://github.com/luxonis/depthai-nodes.git@feat/dai_dev_req | |||
There was a problem hiding this comment.
The PR description states this should be merged after the new depthai_nodes release (0.3.8), but the requirements are pointing to a git branch instead of the version number. This should be updated to use the released version once depthai-nodes 0.3.8 is published to ensure reproducible builds and proper dependency management.
Purpose
Update codebase to new snaps update
Specification
Changed the existing examples who use SnapsUploder/SnapsData to use new version of SnapsUploder/SnapsData
Dependencies & Potential Impact
Depends on snapsUpdate PR and new depthai_nodes release
Deployment Plan
Has to be merged after new depthai_nodes release (0.3.8)
Testing & Validation
Manually tested