Open
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="lv_conf.h">
<violation number="1" location="lv_conf.h:255">
`LV_USE_PXP` is still the controlling flag for this block, but the new guard defines `LV_USE_DRAW_PXP` instead, leaving `LV_USE_PXP` undefined so the feature can never be enabled.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
lv_conf.h
Outdated
| /** Use NXP's PXP on iMX RTxxx platforms. */ | ||
| #define LV_USE_PXP 0 | ||
| #ifndef LV_USE_DRAW_PXP | ||
| #define LV_USE_DRAW_PXP 0 |
There was a problem hiding this comment.
LV_USE_PXP is still the controlling flag for this block, but the new guard defines LV_USE_DRAW_PXP instead, leaving LV_USE_PXP undefined so the feature can never be enabled.
Prompt for AI agents
Address the following comment on lv_conf.h at line 255:
<comment>`LV_USE_PXP` is still the controlling flag for this block, but the new guard defines `LV_USE_DRAW_PXP` instead, leaving `LV_USE_PXP` undefined so the feature can never be enabled.</comment>
<file context>
@@ -249,7 +251,9 @@
/** Use NXP's PXP on iMX RTxxx platforms. */
-#define LV_USE_PXP 0
+#ifndef LV_USE_DRAW_PXP
+#define LV_USE_DRAW_PXP 0
+#endif
</file context>
67982bc to
17c31f7
Compare
Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on getting LVGL working cleanly on the NXP 1170 EVK with a LVGL v9 compatible driver in progress here: https://github.com/andrewleech/imxrt1170_display_driver
These minimal changes to the LVGL bindings files enables the build environment to enable port specific features more easily.
Summary by cubic
Add basic NXP i.MX RT (mimxrt) support by enabling port-specific LVGL GPU/PXP configuration and wiring build flags for the mimxrt port. This allows LVGL v9 to run on the RT1170 EVK with PXP acceleration.
Written for commit 09a4d3c. Summary will update automatically on new commits.