esp32: allow external USER_C_MODULES from command line#100
Merged
PGNetHun merged 1 commit intolvgl:masterfrom Jul 14, 2025
Merged
esp32: allow external USER_C_MODULES from command line#100PGNetHun merged 1 commit intolvgl:masterfrom
PGNetHun merged 1 commit intolvgl:masterfrom
Conversation
PGNetHun
approved these changes
Jul 14, 2025
Collaborator
PGNetHun
left a comment
PGNetHun
left a comment
There was a problem hiding this comment.
Thanks!
PS:
there will be another PR to update the lv_binding_micropython submodule after all the approved PRs are merged there
Collaborator
The other PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The esp32 port hardcodes USER_C_MODULES to point to lv_binding_micropython and breaks the ability to pass in additional user modules via command line. This PR fixes that issue
Testing
I successfully built the esp32 port both with and without additional user modules
Note: this is a dup of #96 but contains only the single relevant commit