Skip to content

feat: support filtering out empty values #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajroetker merged 1 commit into from
Jun 27, 2025
Merged

feat: support filtering out empty values #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions expr/builtins/builtins_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,8 @@ var builtinTests = []testBuiltins{
{`filter(split("apples,oranges",","),"ora%")`, value.NewStringsValue([]string{"apples"})},
{`filter(split("apples,oranges",","),["ora%","ban*"])`, value.NewStringsValue([]string{"apples"})},
{`filter(split("apples,oranges",","), ["ora*","notmatch","stuff"] )`, value.NewStringsValue([]string{"apples"})},
{`filter(split("apples,oranges,",","), [""] )`, value.NewStringsValue([]string{"apples", "oranges"})},
{`filter("apples","")`, value.NewStringValue("apples")},
{`filter("apples","ban*")`, value.NewStringValue("apples")},
{`filter("apples","ban")`, value.NewStringValue("apples")},
{`filter("apples","app*")`, value.NilValueVal},
Expand Down
15 changes: 15 additions & 0 deletions expr/builtins/filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ func FilterEval(ctx expr.EvalContext, vals []value.Value) (value.Value, bool) {
filteredOut = true
break
}
} else if filter == "" {
if rowKey == "" && v != nil {
filteredOut = true
break
}
} else {
if strings.HasPrefix(rowKey, filter) && v != nil {
filteredOut = true
Expand All @@ -132,6 +137,11 @@ func FilterEval(ctx expr.EvalContext, vals []value.Value) (value.Value, bool) {
anyMatches = true
break
}
} else if filter == "" {
if val.Val() == "" {
anyMatches = true
break
}
} else {
if strings.HasPrefix(val.Val(), filter) {
anyMatches = true
Expand All @@ -157,6 +167,11 @@ func FilterEval(ctx expr.EvalContext, vals []value.Value) (value.Value, bool) {
filteredOut = true
break
}
} else if filter == "" {
if sv == "" {
Copy link
Contributor

@ajroetker ajroetker Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit but we should filter out nil values too

filteredOut = true
break
}
} else {
if strings.HasPrefix(sv, filter) && sv != "" {
filteredOut = true
Expand Down