chore: remove console.log statements from production code#102
Closed
Kunal1522 wants to merge 1 commit intom-lab:mainfrom
Closed
chore: remove console.log statements from production code#102Kunal1522 wants to merge 1 commit intom-lab:mainfrom
Kunal1522 wants to merge 1 commit intom-lab:mainfrom
Conversation
Three console.log calls were left in measure.js from development: - Logs server machine and location on every NDT test start - Logs the full NDT downloadComplete data object - Logs MSAK server machine name on download start These expose internal data structures to any user who opens browser DevTools and add noise to the console in production.
Contributor
|
Same reasoning as with #101 - this is mostly intentional, and valuable debug information when something does not work. Nothing about server name and location is supposed to be private, anyway. In fact, we encourage looking at the JS console in case of issues, and knowing the exact server has been helpful in the past. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three
console.logcalls were left inmeasure.jsfrom development:downloadCompletedata object to the consoleThese expose internal data structures to any user who opens browser DevTools.
Fix
Removed all three
console.logcalls frommeasure.js.