Closed
Conversation
Add a dedicated workflow that runs actionlint on all .github/workflows/ YAML files to catch syntax errors, invalid expressions, and misconfigured actions before they reach main. Key behaviours: - Only triggers when workflow files change (paths filter) - Pinned to actionlint@v1.7.7 for reproducibility - Concurrency group cancels redundant runs on rapid pushes - 5 minute timeout — lint should never hang
Add a spell check CI job using crate-ci/typos that runs on every push to main and every pull request. M-Lab specific terms (mlab, msak, ndt, ndt7, oti) are whitelisted via the extend_words input to prevent false positives. typos is a fast Rust-based spell checker that catches common misspellings in source code, comments, and documentation without requiring any extra tooling or config files.
Kunal1522
force-pushed
the
ci/spellcheck
branch
from
c6afe47 to
2b3f8bb
Compare
Replace separate spelling.yml with a unified lint.yml that runs both actionlint and cspell as parallel jobs. - actionlint: validates GitHub Actions workflow YAML syntax - cspell: spell checks all source files using actual dictionaries (used by OWASP NestJS, VS Code, TypeScript) cspell config is inline via inline_config — no separate .cspell.json needed. M-Lab specific terms and tool names are whitelisted in the words array.
Kunal1522
force-pushed
the
ci/spellcheck
branch
from
2b3f8bb to
adf7615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a spell checking CI job using crate-ci/typos that runs on every push to
mainand every pull request.Changes
.github/workflows/spelling.yml— single workflow file, no extra config filesDesign
extend_wordsinput used to whitelist M-Lab specific terms (mlab,msak,ndt,ndt7,oti) inline — avoids needing a separate_typos.tomlcrate-ci/typos@v1.29.10for reproducibilitytimeout-minutes: 5— typos completes in secondsWhy typos
Notes