Skip to content

Comments

Fixes#123-dead code cb after return#158

Closed
Sanskar12G wants to merge 2 commits intom-lab:mainfrom
Sanskar12G:fix/dead-code-cb-after-return
Closed

Fixes#123-dead code cb after return#158
Sanskar12G wants to merge 2 commits intom-lab:mainfrom
Sanskar12G:fix/dead-code-cb-after-return

Conversation

@Sanskar12G
Copy link

Fixes : #123
Problem
In both translations and pot task functions, cb() was placed
after a return statement making it dead code that can never be
executed.

Fix
Since both functions return a stream, Gulp 4 handles task completion
automatically. Removed the unnecessary 'cb' parameter and dead cb()
calls from both functions.

Changes

  • gulpfile.js: removed 'cb' parameter from translations function
  • gulpfile.js: removed 'cb' parameter and dead 'cb()' from pot function

@robertodauria
Copy link
Contributor

Thanks for the contribution, but we require prior coordination with a maintainer before opening PRs. Please also check existing issues and PRs — the gulpfile is being replaced as part of the build system modernization tracked in #83.

Please see our engagement requirements.

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: unreachable cb() calls after return statement in translations and pot tasks

2 participants